Introduce apm-server.response_headers config #4523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Like apm-server.rum.response_headers, but for all HTTP responses. If both are defined, then they will both be added to RUM responses.
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Steps errors
Expand to view the steps failures
|
Codecov Report
@@ Coverage Diff @@
## master #4523 +/- ##
==========================================
- Coverage 75.94% 75.92% -0.03%
==========================================
Files 161 161
Lines 9783 9786 +3
==========================================
Hits 7430 7430
- Misses 2353 2356 +3
|
jalvz
approved these changes
Dec 14, 2020
axw
added a commit
to axw/apm-server
that referenced
this pull request
Dec 15, 2020
* Introduce apm-server.response_headers config Like apm-server.rum.response_headers, but for all HTTP responses. If both are defined, then they will both be added to RUM responses.
simitt
pushed a commit
that referenced
this pull request
Dec 15, 2020
|
Tested with BC1 - works as expected. @axw response headers are not applied to the Jaeger http endpoint but I assume that's also not required. |
Hmm I had forgotten about that TBH. I think that's OK for the moment since the Jaeger has its own config, and we'll add it on if/when we mux them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation/summary
Like
apm-server.rum.response_headers, but for all HTTP responses. If both are defined, then they will both be added to RUM responses, with values for the same key concatenated.Checklist
I have considered changes for:
- [ ] logging (add log lines, choose appropriate log selector, etc.)- [ ] metrics and monitoring (create issue for Kibana team to add metrics to visualizations, e.g. Kibana#44001)- [ ] telemetry- [ ] Elasticsearch Service (https://cloud.elastic.co)- [ ] Elastic Cloud Enterprise (https://www.elastic.co/products/ece)- [ ] Elastic Cloud on Kubernetes (https://www.elastic.co/elastic-cloud-kubernetes)How to test these changes
cd systemtest && go test -vRelated issues
Closes #4522