Skip to content

Conversation

@axw
Copy link
Member

@axw axw commented Apr 13, 2021

Motivation/summary

In the Fleet integration system test, bootstrap Fleet Server and then run the APM integration on a separate Elastci Agent that enrolls with the Fleet Server.

Related issues

Closes #5075

@axw axw added the v7.13.0 label Apr 13, 2021
@axw axw force-pushed the systemtest-fleet-server branch from 28d8638 to 8cfe40c Compare April 13, 2021 09:51
@ghost
Copy link

ghost commented Apr 13, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #5085 updated

  • Start Time: 2021-04-15T08:24:50.347+0000

  • Duration: 38 min 2 sec

  • Commit: 0114fb7

Test stats 🧪

Test Results
Failed 0
Passed 6278
Skipped 120
Total 6398

Trends 🧪

Image of Build Times

Image of Tests

@axw axw force-pushed the systemtest-fleet-server branch 2 times, most recently from 5096b94 to 51c8c7e Compare April 14, 2021 05:02
@axw axw marked this pull request as ready for review April 14, 2021 06:06
@axw axw requested a review from a team April 14, 2021 06:06
@codecov-io
Copy link

Codecov Report

Merging #5085 (e1e572e) into master (bb856fc) will increase coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #5085      +/-   ##
==========================================
+ Coverage   77.30%   77.35%   +0.04%     
==========================================
  Files         179      179              
  Lines       10540    10540              
==========================================
+ Hits         8148     8153       +5     
+ Misses       2392     2387       -5     
Impacted Files Coverage Δ
...ack/apm-server/aggregation/txmetrics/aggregator.go 93.24% <0.00%> (ø)
kibana/connecting_client.go 76.56% <0.00%> (+7.81%) ⬆️

@axw axw marked this pull request as draft April 14, 2021 09:08
@axw
Copy link
Member Author

axw commented Apr 14, 2021

test seems to be flaky, bringing back into draft while I debug...

@axw axw force-pushed the systemtest-fleet-server branch from e1e572e to 1bbef5b Compare April 15, 2021 06:39
@axw axw marked this pull request as ready for review April 15, 2021 07:32
Copy link
Contributor

@simitt simitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great.

if c.FleetEnrollmentToken != "" {
if c.FleetServer {
c.request.Env["FLEET_SERVER_ENABLE"] = "1"
c.request.Env["FLEET_SERVER_HOST"] = "0.0.0.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't be necessary anymore afaik.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just tried removing FLEET_SERVER_HOST and FLEET_SERVER_PORT (and tried just removing each individually), and the server never became accessible. In the elastic-agent log I see "State changed to CONFIG: Re-configuring". Maybe a bug masked by overriding the host/port?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to merge as it is and come back to this, so we can get our system tests running again

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes sure; thanks for trying it out.

@axw axw merged commit 139ce53 into elastic:master Apr 15, 2021
@axw axw deleted the systemtest-fleet-server branch April 15, 2021 09:06
mergify bot pushed a commit that referenced this pull request Apr 15, 2021
* systemtest: use Fleet Server

* systemtest: fix bulk unenrolment

(cherry picked from commit 139ce53)
axw added a commit that referenced this pull request Apr 19, 2021
* systemtest: use Fleet Server

* systemtest: fix bulk unenrolment

(cherry picked from commit 139ce53)

Co-authored-by: Andrew Wilkins <axw@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update system tests to use Fleet Server

3 participants