-
Notifications
You must be signed in to change notification settings - Fork 543
systemtest: use Fleet Server #5085
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
28d8638 to
8cfe40c
Compare
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪 |
5096b94 to
51c8c7e
Compare
Codecov Report
@@ Coverage Diff @@
## master #5085 +/- ##
==========================================
+ Coverage 77.30% 77.35% +0.04%
==========================================
Files 179 179
Lines 10540 10540
==========================================
+ Hits 8148 8153 +5
+ Misses 2392 2387 -5
|
|
test seems to be flaky, bringing back into draft while I debug... |
e1e572e to
1bbef5b
Compare
simitt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great.
| if c.FleetEnrollmentToken != "" { | ||
| if c.FleetServer { | ||
| c.request.Env["FLEET_SERVER_ENABLE"] = "1" | ||
| c.request.Env["FLEET_SERVER_HOST"] = "0.0.0.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't be necessary anymore afaik.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just tried removing FLEET_SERVER_HOST and FLEET_SERVER_PORT (and tried just removing each individually), and the server never became accessible. In the elastic-agent log I see "State changed to CONFIG: Re-configuring". Maybe a bug masked by overriding the host/port?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to merge as it is and come back to this, so we can get our system tests running again
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes sure; thanks for trying it out.
* systemtest: use Fleet Server * systemtest: fix bulk unenrolment (cherry picked from commit 139ce53)
Motivation/summary
In the Fleet integration system test, bootstrap Fleet Server and then run the APM integration on a separate Elastci Agent that enrolls with the Fleet Server.
Related issues
Closes #5075