-
Notifications
You must be signed in to change notification settings - Fork 529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add content to APM User guide #6378
Conversation
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
docs/manage-storage.asciidoc
Outdated
POST *-apm-*/_update_by_query | ||
{ | ||
"query": { | ||
"term": { | ||
"service.name": { | ||
"value": "current-service-name" | ||
} | ||
} | ||
}, | ||
"script": { | ||
"source": "ctx._source.service.name = 'new-service-name'", | ||
"lang": "painless" | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm struggling to update this query. The _search
works correctly, for example:
GET *-apm-*/_search
{
"query": {
"term": {
"service.name": {
"value": "opbeans-dotnet"
}
}
}
}
But running the script
returns 0
updates.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure why this is necessary, but try adding ?expand_wildcards=all
. I thought the default would match it... maybe a bug?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…content # Conflicts: # docs/integrations-index.asciidoc
@elastic/apm-server Unfortunately, this PR is blocking me. If it's alright with y'all, I'm going to merge it tomorrow morning (PDT) so I can keep moving forward with docs updates. I know you're all super busy right now, so we can always review later and make updates in a future PR 😄 |
@bmorelli25 sorry, please go ahead and merge and we can do a post-merge review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
[[view-edit-default-pipelines]] | ||
=== View or edit a default pipeline | ||
|
||
To view or edit a default pipelines in {kib}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re "edit", we should make sure to document that the Fleet-managed ingest policy will be overwritten on reinstall/upgrade. Users can define their own custom ingest pipeline if needed, but they need make sure that they also call the package-provided pipeline.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me know if I'm understanding this correctly:
- Fleet adds ingest pipelines for the APM integration using index templates that include pipeline index settings.
- Elasticsearch uses the index pattern in these index templates to match pipelines to APM data streams.
As an example, the index template traces-apm
, matches traces-apm-*
data streams and assigns the "traces-apm-7.16.0"
pipeline:
- This, Fleet managed, index template ⬆️ will be overwritten on reinstall/upgrade.
Assuming the above is correct, then I see three scenarios:
-
If a user edits the Fleet managed index template to point to a new pipeline, they need to:
a. ensure the package-provided pipeline is also called
b. know that the index template will be overwritten on install/upgrade -
If a user creates a custom component template with a higher priority that points to a new pipeline, they need to:
a. ensure the package-provided pipeline is also called
b. not sure what happens on upgrade here -
If a user edits the pipeline directly, like the
"traces-apm-7.16.0"
pipeline, they need to:
a. ensure the package-provided pipelines are still included
b. know that their edits will be overwritten on install/upgrade
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had thought that the default pipeline was defined in the @settings
component template, which would allow it to be overridden. That is not the case, so #2 isn't possible actually. I believe at the moment users would be limited to #1 and #3. We'll need to improve this. CC @simitt
Users shouldn't need to care about upgrades, but rather they should have some way of hooking their own custom pipeline into a predefined location in the Fleet-managed ingest pipeline.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect. Thanks, Andrew!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
started elastic/package-spec#129 a while back; @ruflin do you have any concerns when moving the default_pipeline
to the component-template instead of the index-template to make it user overridable?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments, but feel free to merge as is and address in a follow up. Apologies for such a long review time.
(cherry picked from commit d9a7812)
(cherry picked from commit d9a7812)
Summary
This PR adds the following content to the APM Guide:
/docs/legacy
directory.Related issues
For elastic/observability-docs#1073.
PRs blocked by this PR