-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[7.17] update beats to update the docker base image #7101
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
simitt
force-pushed
the
7.17-update-beats
branch
from
January 20, 2022 18:51
acab077
to
5111d3e
Compare
graphaelli
approved these changes
Jan 20, 2022
/test |
@graphaelli please see the updated description regarding reverting back the |
/test |
/test |
This was referenced Jan 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation/summary
Beats changed the docker base image from
centos
toubuntu 20.04
. Updating beats is required to also apply the change to APM Server.This pulls in breaking changes from libbeat related to idxmgmt; elastic/beats@84bf434#diff-701b51cb205dec9db43f1a3cd736b11c6123705c17be1786570c264bcb6c93f8 adds
IsAlias()
to theIndexSelector
Interface. It enables the output handler to require analias
instead of anindex
when ingesting data. This PR introduces the missing function, but for now always returnsfalse
for theIsAlias()
check. Even when ILM is enabled, APM Server still needs to write to indices forsourcemaps
andonboarding
. Therefore the newly introduced check cannot simply be leveraged by APM at this point.Checklist
How to test these changes
DEV=true SNAPSHOT=true PLATFORMS=linux/amd64 TYPES=docker mage package
Related issues
related to elastic/beats#29255