Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.17] update beats to update the docker base image #7101

Merged
merged 8 commits into from
Jan 21, 2022

Conversation

simitt
Copy link
Contributor

@simitt simitt commented Jan 20, 2022

Motivation/summary

Beats changed the docker base image from centos to ubuntu 20.04. Updating beats is required to also apply the change to APM Server.

This pulls in breaking changes from libbeat related to idxmgmt; elastic/beats@84bf434#diff-701b51cb205dec9db43f1a3cd736b11c6123705c17be1786570c264bcb6c93f8 adds IsAlias() to the IndexSelector Interface. It enables the output handler to require an alias instead of an index when ingesting data. This PR introduces the missing function, but for now always returns false for the IsAlias() check. Even when ILM is enabled, APM Server still needs to write to indices for sourcemaps and onboarding. Therefore the newly introduced check cannot simply be leveraged by APM at this point.

Checklist

How to test these changes

  • Build docker image DEV=true SNAPSHOT=true PLATFORMS=linux/amd64 TYPES=docker mage package
  • Start apm-server docker image and exec into it
  • Ensure the base image is Ubuntu 20.04
apm-server@bcf8c1e2426b:~$ cat /etc/redhat-release /etc/lsb-release /etc/debian_version
cat: /etc/redhat-release: No such file or directory
DISTRIB_ID=Ubuntu
DISTRIB_RELEASE=20.04
DISTRIB_CODENAME=focal
DISTRIB_DESCRIPTION="Ubuntu 20.04.3 LTS"
bullseye/sid

Related issues

related to elastic/beats#29255

@apmmachine
Copy link
Contributor

apmmachine commented Jan 20, 2022

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /hey-apm : Run the hey-apm benchmark.

  • /package : Generate and publish the docker images.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@simitt
Copy link
Contributor Author

simitt commented Jan 20, 2022

/test

@simitt
Copy link
Contributor Author

simitt commented Jan 20, 2022

@graphaelli please see the updated description regarding reverting back the alias related check for idxmgmt handling.

@simitt
Copy link
Contributor Author

simitt commented Jan 20, 2022

/test

@simitt
Copy link
Contributor Author

simitt commented Jan 21, 2022

/test

@simitt simitt marked this pull request as ready for review January 21, 2022 12:46
@simitt simitt merged commit 61503b6 into elastic:7.17 Jan 21, 2022
@simitt simitt deleted the 7.17-update-beats branch April 21, 2022 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants