Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow gencorpora to replay events #8952

Merged
merged 4 commits into from
Aug 25, 2022

Conversation

lahsivjar
Copy link
Contributor

Motivation/summary

By playing the recorded events without replay the ES corpus has 18817 documents accounting for ~56MBs of data. This PR allows replaying events in order to increase the corpus size for testing with rally. APM-Server might aggregate some events thus the generated corpus will not always be a multiple of the replay count.

Checklist

- [ ] Update CHANGELOG.asciidoc
- [ ] Update package changelog.yml (only if changes to apmpackage have been made)
- [ ] Documentation has been updated

How to test these changes

N/A

Related issues

Part of: #8754

@mergify
Copy link
Contributor

mergify bot commented Aug 24, 2022

This pull request does not have a backport label. Could you fix it @lahsivjar? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-7.x is the label to automatically backport to the 7.x branch.
  • backport-7./d is the label to automatically backport to the 7./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Aug 24, 2022
@lahsivjar lahsivjar requested a review from a team August 24, 2022 11:03
@apmmachine
Copy link
Contributor

apmmachine commented Aug 24, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-08-25T03:33:06.969+0000

  • Duration: 29 min 17 sec

Test stats 🧪

Test Results
Failed 0
Passed 129
Skipped 0
Total 129

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate and publish the docker images.

  • /test windows : Build & tests on Windows.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@apmmachine
Copy link
Contributor

apmmachine commented Aug 24, 2022

📚 Go benchmark report

Diff with the main branch

name                                                                                              old time/op    new time/op     delta
pkg:github.com/elastic/apm-server/internal/agentcfg goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/internal/decoder goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/internal/model/modelindexer goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/internal/processor/stream goos:linux goarch:amd64
BackendProcessor/invalid-metadata.ndjson-12                                                         2.66µs ± 2%     2.73µs ± 1%   +2.67%  (p=0.016 n=5+5)
BackendProcessor/ratelimit.ndjson-12                                                                 176µs ±32%      235µs ± 7%  +33.24%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel2/invalid-metadata-2.ndjson-12            1.57µs ± 2%     1.72µs ± 7%   +9.61%  (p=0.016 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel2/metadata.ndjson-12                      4.18µs ± 1%     4.47µs ± 9%   +6.76%  (p=0.016 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel4/errors_transaction_id.ndjson-12         11.7µs ± 8%     13.6µs ± 8%  +16.26%  (p=0.016 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel4/invalid-json-metadata.ndjson-12         4.45µs ± 8%     4.15µs ± 2%   -6.82%  (p=0.032 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel4/metricsets.ndjson-12                    13.9µs ± 6%     15.5µs ± 4%  +10.90%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel4/otel-bridge.ndjson-12                   8.66µs ±12%     9.53µs ± 5%  +10.02%  (p=0.032 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel4/ratelimit.ndjson-12                     36.0µs ±20%     41.3µs ± 6%  +14.85%  (p=0.032 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel4/span-links.ndjson-12                    3.98µs ± 9%     4.57µs ±12%  +14.80%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel4/transactions_spans_rum_2.ndjson-12      4.76µs ±11%     5.60µs ±11%  +17.51%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel8/errors_rum.ndjson-12                    2.54µs ± 1%     2.57µs ± 0%   +1.45%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel8/transactions.ndjson-12                  15.0µs ± 1%     15.5µs ± 1%   +3.27%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel8/transactions_spans.ndjson-12            18.6µs ± 1%     19.0µs ± 0%   +2.11%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel8/transactions_spans_rum.ndjson-12        2.59µs ± 1%     2.70µs ± 1%   +4.06%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel8/transactions_spans_rum_2.ndjson-12      2.51µs ± 1%     2.63µs ± 2%   +4.77%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel8/unknown-span-type.ndjson-12             7.95µs ± 1%     8.30µs ± 3%   +4.31%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/errors.ndjson-12                      10.1µs ± 1%     11.0µs ± 1%   +8.44%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/errors_2.ndjson-12                    7.94µs ± 1%     8.66µs ± 1%   +9.07%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/errors_rum.ndjson-12                  2.03µs ± 3%     2.21µs ± 1%   +9.06%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/errors_transaction_id.ndjson-12       5.32µs ± 2%     5.74µs ± 3%   +7.95%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/events.ndjson-12                      14.5µs ± 1%     15.6µs ± 0%   +7.81%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/heavy.ndjson-12                       1.53ms ± 2%     1.61ms ± 2%   +5.22%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/invalid-event-type.ndjson-12           724ns ± 2%      797ns ± 2%  +10.07%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/invalid-event.ndjson-12               3.34µs ± 4%     3.60µs ± 1%   +7.89%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/invalid-json-event.ndjson-12          1.22µs ± 1%     1.27µs ± 1%   +4.12%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/invalid-json-metadata.ndjson-12       1.89µs ± 0%     1.97µs ± 1%   +4.21%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/invalid-metadata-2.ndjson-12           490ns ± 1%      509ns ± 2%   +3.90%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/invalid-metadata.ndjson-12             494ns ± 1%      513ns ± 3%   +3.78%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/metadata-null-values.ndjson-12         936ns ± 2%      998ns ± 1%   +6.62%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/metadata.ndjson-12                    1.22µs ± 1%     1.29µs ± 1%   +5.05%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/metricsets.ndjson-12                  5.91µs ± 1%     6.18µs ± 2%   +4.58%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/minimal-service.ndjson-12             1.67µs ± 3%     1.74µs ± 1%   +4.40%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/minimal.ndjson-12                     4.89µs ± 1%     5.13µs ± 1%   +5.05%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/optional-timestamps.ndjson-12         2.97µs ± 2%     3.11µs ± 1%   +4.67%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/otel-bridge.ndjson-12                 3.70µs ± 4%     3.93µs ± 2%   +6.43%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/ratelimit.ndjson-12                   16.0µs ± 1%     16.7µs ± 1%   +4.69%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/span-links.ndjson-12                  1.76µs ± 3%     1.86µs ± 3%   +5.63%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/spans.ndjson-12                       15.0µs ± 1%     15.8µs ± 3%   +4.95%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/transactions-huge_traces.ndjson-12    4.80µs ± 2%     5.03µs ± 2%   +4.70%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/transactions.ndjson-12                12.6µs ± 1%     13.3µs ± 1%   +5.26%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/transactions_spans.ndjson-12          15.6µs ± 1%     16.5µs ± 1%   +6.36%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/transactions_spans_rum.ndjson-12      2.15µs ± 1%     2.27µs ± 1%   +5.50%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/transactions_spans_rum_2.ndjson-12    2.10µs ± 2%     2.21µs ± 1%   +5.59%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/unknown-span-type.ndjson-12           6.68µs ± 1%     6.99µs ± 0%   +4.63%  (p=0.016 n=5+4)
pkg:github.com/elastic/apm-server/internal/publish goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/x-pack/apm-server/aggregation/spanmetrics goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/x-pack/apm-server/aggregation/txmetrics goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/x-pack/apm-server/sampling goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/x-pack/apm-server/sampling/eventstorage goos:linux goarch:amd64
ReadEvents/nop_codec/1_events-12                                                                    2.15µs ± 7%     1.92µs ± 6%  -11.03%  (p=0.008 n=5+5)
ReadEvents/nop_codec/100_events-12                                                                   126µs ±14%      147µs ± 6%  +16.81%  (p=0.032 n=5+5)
ReadEvents/nop_codec_big_tx/1000_events-12                                                           963µs ± 8%      869µs ± 5%   -9.83%  (p=0.016 n=5+5)
IsTraceSampled/unsampled-12                                                                         70.4ns ± 1%     71.3ns ± 1%   +1.32%  (p=0.032 n=5+5)

name                                                                                              old alloc/op   new alloc/op    delta
pkg:github.com/elastic/apm-server/internal/agentcfg goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/internal/decoder goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/internal/model/modelindexer goos:linux goarch:amd64
ModelIndexer/NoCompression-12                                                                       3.33kB ± 1%     3.28kB ± 2%   -1.58%  (p=0.008 n=5+5)
pkg:github.com/elastic/apm-server/internal/processor/stream goos:linux goarch:amd64
BackendProcessor/events.ndjson-12                                                                   58.6kB ± 1%     59.5kB ± 1%   +1.48%  (p=0.032 n=5+5)
BackendProcessor/invalid-event.ndjson-12                                                            11.0kB ± 3%     10.7kB ± 1%   -2.81%  (p=0.032 n=5+5)
BackendProcessor/spans.ndjson-12                                                                    94.9kB ± 0%     96.6kB ± 1%   +1.81%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel2/invalid-event.ndjson-12                 10.5kB ± 1%     10.7kB ± 2%   +1.38%  (p=0.040 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel2/transactions_spans.ndjson-12            93.0kB ± 0%     93.5kB ± 1%   +0.45%  (p=0.048 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel4/transactions_spans.ndjson-12            92.8kB ± 1%     91.7kB ± 1%   -1.22%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel8/errors_rum.ndjson-12                    10.5kB ± 0%     10.4kB ± 1%   -0.87%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/metadata.ndjson-12                    5.28kB ± 0%     5.24kB ± 1%   -0.63%  (p=0.016 n=4+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/otel-bridge.ndjson-12                 17.8kB ± 0%     17.8kB ± 0%   -0.38%  (p=0.032 n=5+5)
pkg:github.com/elastic/apm-server/internal/publish goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/x-pack/apm-server/aggregation/spanmetrics goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/x-pack/apm-server/aggregation/txmetrics goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/x-pack/apm-server/sampling goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/x-pack/apm-server/sampling/eventstorage goos:linux goarch:amd64

name                                                                                              old allocs/op  new allocs/op   delta
pkg:github.com/elastic/apm-server/internal/agentcfg goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/internal/decoder goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/internal/model/modelindexer goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/internal/processor/stream goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/internal/publish goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/x-pack/apm-server/aggregation/spanmetrics goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/x-pack/apm-server/aggregation/txmetrics goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/x-pack/apm-server/sampling goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/x-pack/apm-server/sampling/eventstorage goos:linux goarch:amd64

name                                                                                              old speed      new speed       delta
pkg:github.com/elastic/apm-server/internal/processor/stream goos:linux goarch:amd64
BackendProcessor/invalid-metadata.ndjson-12                                                        168MB/s ± 2%    163MB/s ± 1%   -2.62%  (p=0.016 n=5+5)
BackendProcessor/ratelimit.ndjson-12                                                              24.8MB/s ±41%   18.0MB/s ± 7%  -27.64%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel2/invalid-metadata-2.ndjson-12           278MB/s ± 2%    255MB/s ± 8%   -8.46%  (p=0.016 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel2/metadata.ndjson-12                     297MB/s ± 1%    279MB/s ± 8%   -6.11%  (p=0.016 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel4/errors_transaction_id.ndjson-12        327MB/s ± 8%    281MB/s ± 8%  -13.97%  (p=0.016 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel4/invalid-json-metadata.ndjson-12        101MB/s ± 8%    108MB/s ± 2%   +7.07%  (p=0.032 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel4/metricsets.ndjson-12                   183MB/s ± 5%    165MB/s ± 4%   -9.89%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel4/otel-bridge.ndjson-12                  218MB/s ±13%    198MB/s ± 5%   -9.43%  (p=0.032 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel4/ratelimit.ndjson-12                    119MB/s ±24%    102MB/s ± 6%  -14.15%  (p=0.032 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel4/span-links.ndjson-12                   172MB/s ±10%    150MB/s ±11%  -12.89%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel4/transactions_spans_rum_2.ndjson-12     236MB/s ±12%    200MB/s ±10%  -14.98%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel8/errors_rum.ndjson-12                   748MB/s ± 1%    737MB/s ± 0%   -1.43%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel8/transactions.ndjson-12                 376MB/s ± 1%    364MB/s ± 1%   -3.17%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel8/transactions_spans.ndjson-12           312MB/s ± 1%    306MB/s ± 0%   -2.07%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel8/transactions_spans_rum.ndjson-12       446MB/s ± 1%    428MB/s ± 1%   -3.90%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel8/transactions_spans_rum_2.ndjson-12     444MB/s ± 1%    424MB/s ± 2%   -4.54%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel8/unknown-span-type.ndjson-12            416MB/s ± 1%    399MB/s ± 3%   -4.11%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/errors.ndjson-12                     627MB/s ± 1%    578MB/s ± 1%   -7.78%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/errors_2.ndjson-12                   594MB/s ± 1%    544MB/s ± 1%   -8.32%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/errors_rum.ndjson-12                 935MB/s ± 3%    857MB/s ± 1%   -8.34%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/errors_transaction_id.ndjson-12      719MB/s ± 2%    666MB/s ± 3%   -7.37%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/events.ndjson-12                     512MB/s ± 1%    475MB/s ± 0%   -7.25%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/heavy.ndjson-12                      261MB/s ± 2%    248MB/s ± 2%   -4.96%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/invalid-event-type.ndjson-12         540MB/s ± 2%    491MB/s ± 2%   -9.14%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/invalid-event.ndjson-12              230MB/s ± 4%    213MB/s ± 1%   -7.38%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/invalid-json-event.ndjson-12         482MB/s ± 1%    463MB/s ± 1%   -3.95%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/invalid-json-metadata.ndjson-12      236MB/s ± 0%    226MB/s ± 1%   -4.04%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/invalid-metadata-2.ndjson-12         891MB/s ± 1%    857MB/s ± 2%   -3.75%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/invalid-metadata.ndjson-12           902MB/s ± 1%    869MB/s ± 3%   -3.63%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/metadata-null-values.ndjson-12       562MB/s ± 2%    527MB/s ± 1%   -6.21%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/metadata.ndjson-12                  1.02GB/s ± 1%   0.97GB/s ± 1%   -4.79%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/metricsets.ndjson-12                 431MB/s ± 1%    412MB/s ± 2%   -4.37%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/minimal-service.ndjson-12            255MB/s ± 3%    244MB/s ± 1%   -4.24%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/minimal.ndjson-12                    211MB/s ± 1%    201MB/s ± 1%   -4.80%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/optional-timestamps.ndjson-12        346MB/s ± 2%    330MB/s ± 1%   -4.46%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/otel-bridge.ndjson-12                509MB/s ± 4%    478MB/s ± 2%   -6.10%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/ratelimit.ndjson-12                  263MB/s ± 1%    252MB/s ± 1%   -4.48%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/span-links.ndjson-12                 388MB/s ± 3%    367MB/s ± 3%   -5.35%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/spans.ndjson-12                      534MB/s ± 1%    509MB/s ± 3%   -4.70%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/transactions-huge_traces.ndjson-12   660MB/s ± 2%    631MB/s ± 2%   -4.49%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/transactions.ndjson-12               449MB/s ± 1%    426MB/s ± 1%   -5.00%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/transactions_spans.ndjson-12         374MB/s ± 1%    352MB/s ± 1%   -5.98%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/transactions_spans_rum.ndjson-12     537MB/s ± 1%    509MB/s ± 1%   -5.20%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/transactions_spans_rum_2.ndjson-12   533MB/s ± 2%    504MB/s ± 1%   -5.29%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/unknown-span-type.ndjson-12          495MB/s ± 1%    473MB/s ± 0%   -4.43%  (p=0.016 n=5+4)

report generated with https://pkg.go.dev/golang.org/x/perf/cmd/benchstat

systemtest/gencorpora/gencorpora.go Outdated Show resolved Hide resolved
systemtest/gencorpora/gencorpora.go Outdated Show resolved Hide resolved
Copy link
Contributor

@marclop marclop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lahsivjar lahsivjar enabled auto-merge (squash) August 25, 2022 02:31
@lahsivjar
Copy link
Contributor Author

/test

@lahsivjar lahsivjar merged commit f978866 into elastic:main Aug 25, 2022
@lahsivjar lahsivjar deleted the gencorpora-replay-events branch August 25, 2022 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-skip Skip notification from the automated backport with mergify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants