-
Notifications
You must be signed in to change notification settings - Fork 527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
spanmetrics: Add 10m
, 60m
aggregation intervals
#9926
Merged
marclop
merged 8 commits into
elastic:main
from
marclop:f/add-service_destination-metrics-ds
Jan 2, 2023
Merged
spanmetrics: Add 10m
, 60m
aggregation intervals
#9926
marclop
merged 8 commits into
elastic:main
from
marclop:f/add-service_destination-metrics-ds
Jan 2, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modifies the `spanmetrics` aggregator to support extra aggregation intervals by introducing a new `RollUpIntervals` (internal only) config option. The configuration option is not user facing, but rather allow us to configure smaller intervals for testing purposes. Also removing the `aggregation.service_destinations.interval` config option. Two new intervals are added and published by default, 10 and 60m (1h). and these are flushed when the APM Server is stopped or restarted. Introduces 3 `metrics-apm.service_destinations.${interval}m` datastreams which contain the mapping definitions for transaction metrics with a series of changes to the apmpackage generator to allow interval templating and individual ILM policies to be tied to each interval. A new `Metricset.Interval` field is added to the ingested documents, to allow them to contain the aggregated interval they represent. The field format is `${interval}m` or `${interval}s` if < 60s. Older APM Servers sending data to an Elasticsearch cluster with updated APM Package, will continue indexing metrics to `metrics-apm.internal`. Last, there's some light refactoring for the `Start` and `Stop` methods to a common `baseaggregator` package which is imported by each of the individual aggregators. Signed-off-by: Marc Lopez Rubio <marc5.12@outlook.com>
Signed-off-by: Marc Lopez Rubio <marc5.12@outlook.com>
Signed-off-by: Marc Lopez Rubio <marc5.12@outlook.com>
marclop
added
enhancement
backport-skip
Skip notification from the automated backport with mergify
labels
Dec 29, 2022
Signed-off-by: Marc Lopez Rubio <marc5.12@outlook.com>
📚 Go benchmark reportDiff with the
report generated with https://pkg.go.dev/golang.org/x/perf/cmd/benchstat |
3 tasks
simitt
approved these changes
Dec 30, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look great; only one minor note about the changelog.
This comment was marked as resolved.
This comment was marked as resolved.
…nation-metrics-ds
…nation-metrics-ds
Signed-off-by: Marc Lopez Rubio <marc5.12@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation/summary
Modifies the
spanmetrics
aggregator to support extra aggregationintervals by introducing a new
RollUpIntervals
(internal only) configoption. The configuration option is not user facing, but rather allow us
to configure smaller intervals for testing purposes. Also removing the
aggregation.service_destinations.interval
config option.Two new intervals are added and published by default, 10 and 60m (1h).
and these are flushed when the APM Server is stopped or restarted.
Introduces 3
metrics-apm.service_destinations.${interval}m
datastreamswhich contain the mapping definitions for transaction metrics with a
series of changes to the apmpackage generator to allow interval
templating and individual ILM policies to be tied to each interval.
A new
Metricset.Interval
field is added to the ingested documents, toallow them to contain the aggregated interval they represent. The field
format is
${interval}m
or${interval}s
if < 60s.Older APM Servers sending data to an Elasticsearch cluster with updated
APM Package, will continue indexing metrics to
metrics-apm.internal
.Last, there's some light refactoring for the
Start
andStop
methodsto a common
baseaggregator
package which is imported by each of theindividual aggregators.
Checklist
apmpackage
have been made)How to test these changes
See linked issue
Related issues
Part of #9703