Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[META 571] Spec: Align on default service name #572

Closed
felixbarny opened this issue Dec 2, 2021 · 2 comments · Fixed by #556
Closed

[META 571] Spec: Align on default service name #572

felixbarny opened this issue Dec 2, 2021 · 2 comments · Fixed by #556

Comments

@felixbarny
Copy link
Member

issue details

Write Spec for:
As defined in #499, agents don't require users to configure the service_name. Ideally, the a descriptive value can be inferred form the application. But in some cases that's not possible. In these cases, agents must now align on the naming scheme for the default service name. This enables the UI to show inline help for services that it identifies as unnamed services based on the naming scheme.

@SylvainJuge
Copy link
Member

@felixbarny when aligning the agents on this new default for service.name, should we consider this as a:

  • "breaking change"
  • "potentially breaking change" ?
  • "not a breaking change"

My first thought would be to not consider this as a breaking change:

  • if a user does not set service.name, they get a default (and likely meaningless) value
  • as a result using a default value is quite unlikely to be used for filtering or in visualizations.

@felixbarny
Copy link
Member Author

I agree to consider this a non-breaking change.

@AlexanderWert AlexanderWert added this to the 7.16 milestone Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants