-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Specify naming scheme of default service name #556
Conversation
💚 Build Succeeded
Expand to view the summary
Build stats
|
Co-authored-by: Sergey Kleyman <SergeyKleyman@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Just to say it out loud (and perhaps help searching), this will change the current unspec'd fallbacks of nodejs_service
and python_service
in the Node.js and Python agents.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM,
similarly to what @trentm says - in .NET the fallback is unknown
and we'll need to change that if this gets merged. (good thing the fallback is really and edge case).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, we will switch to unknown
in the RUM agent. Right now RUM agent does not have zero config support, I have opened elastic/apm-agent-rum-js#1103 to address this.
For RUM, the default would be |
Also turns some SHOULDs into MUSTs
CODEOWNERS
)Relates to https://github.com/elastic/observability-design/issues/21
/cc @formgeist