Agent spec process

[felixbarny]

Let's make this PR an example of the process it describes.

@gregkalapos would you volunteer to be the reviewer of the draft?

supersedes #192

The agent table, not very useful in this case as there's nothing to implement but still useful for showcasing the process this PR proposes.

Agent	Milestone	Link to agent implementation issue
.NET	n/a	nothing to implement
Go	n/a	nothing to implement
Java	n/a	nothing to implement
Node.js	n/a	nothing to implement
PHP	n/a	nothing to implement
Python	n/a	nothing to implement
Ruby	n/a	nothing to implement
RUM	n/a	nothing to implement

[gregkalapos]

@gregkalapos would you volunteer to be the reviewer of the draft?

Sure, let's do this!

[gregkalapos]

The draft looks good to me 👍

[felixbarny]

I've created a bash script to batch-create agent issues using https://github.com/cli/cli

#!/bin/bash

set -ex

AGENTS=()
while [[ "$#" -gt 0 ]]; do
    case $1 in
        --all-agents) AGENTS=(dotnet go java nodejs php python ruby rum-js); ;;
        -a|--agent) AGENTS+=("$2"); shift ;;
        -t|--title) title="$2"; shift ;;
        -b|--body) body="$2"; shift ;;
        -m|--milestone) milestone="$2"; shift ;;
        *) echo "Unknown parameter passed: $1"; exit 1 ;;
    esac
    shift || true
done

: "${AGENTS:?Variable not set or empty}"
: "${title:?Variable not set or empty}"
: "${body:?Variable not set or empty}"
: "${milestone:?Variable not set or empty}"

echo $AGENTS

for agent in "${AGENTS[@]}" ; do
  echo $agent
  gh repo clone elastic/apm-agent-$agent || true
  pushd apm-agent-$agent
  gh issue create --title "$title" --body "$body" --milestone $milestone
  popd
done

One caveat is that the milestone has to exist in the agent repo. It also clones all repos the first time it's executed.

[felixbarny]

I've marked this PR as ready for review now. This means one more agent approval and one PM approval is required. After that, everyone's got 1 week to object by requesting changes. After that the PR will be merged and the changes are effective.

[basepi]

This looks excellent. One request below. But overall I'm very excited about this process change, it will make it much clearer when a spec is final.

[axw]

Good stuff!

[mikker]

Love it 👍

[nehaduggal]

++ for this proposal. I'd suggest adding another table that identifies if we plan to implement a change/addition to all other agents as a part of the spec PR. It'll make it easy to track if all/some agents plan to implement that feature(with a rough milestone) or if its not applicable at all.

[felixbarny]

We have approval from at least two agents and from PM now. So normally, there would be one more week for agent teams to object.

However, since all agent teams have already approved the PR, I think we can proceed.

I'll merge the PR tomorrow so this is the last call for objections.