-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split spec into multiple files #315
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally, I like it a lot. Did you consider merging some of the shorter "chapters", e.g. spans and transactions, or exception tracking and log correlation? That would give those pages a bit more substance.
I think the missing substance mainly means that these areas are underspecified at the moment. For exception tracking and log correlation, I think those topics are not related enough to be in one file. In general, I'm more comfortable with short spec files than mixing things that are not coherent. Similar to how I'd structure source code. |
because there are no actual changes to the spec, only it's structure |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I think this will be much more maintainable and readable.
Based on the many 👍 I got on slack, I'm going to merge this now so that I can rebase the other spec PRs on top of it. |
This splits the monolithic spec into smaller files. It also creates a README.md on the
agents
dir and renamesdocs/agents
tospecs/agents
.We started that with recent spec proposals like #307 and https://github.com/elastic/apm/pull/314/files. Mainly because the files are more coherent and smaller that way. When having the whole spec in one file, that could grow quite big. Especially going forward when we’ll hopefully have specs for all new cross-agent features.
This will cause quite a few conflicts with existing spec PRs. I want to merge this one first and then I’ll resolve the conflicts on the spec PRs. This will make it clearer what has actually changed on the spec PRs.
Preview: https://github.com/felixbarny/apm/tree/modular-spec/specs/agents