Skip to content

Commit

Permalink
Simplifying retryer now that workqueue is used across output loads
Browse files Browse the repository at this point in the history
  • Loading branch information
ycombinator committed Apr 20, 2020
1 parent a59a56e commit 041922b
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 10 deletions.
1 change: 0 additions & 1 deletion libbeat/publisher/pipeline/controller.go
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,6 @@ func (c *outputController) Set(outGrp outputs.Group) {
c.retryer.sigOutputRemoved()
}
}
c.retryer.updOutput(c.workQueue)
for range clients {
c.retryer.sigOutputAdded()
}
Expand Down
9 changes: 0 additions & 9 deletions libbeat/publisher/pipeline/retry.go
Original file line number Diff line number Diff line change
Expand Up @@ -112,13 +112,6 @@ func (r *retryer) sigOutputRemoved() {
r.sig <- retryerSignal{tag: sigRetryerOutputRemoved}
}

func (r *retryer) updOutput(ch workQueue) {
r.sig <- retryerSignal{
tag: sigRetryerUpdateOutput,
channel: ch,
}
}

func (r *retryer) retry(b Batch) {
r.in <- batchEvent{tag: retryBatch, batch: b}
}
Expand Down Expand Up @@ -212,8 +205,6 @@ func (r *retryer) loop() {

case sig := <-r.sig:
switch sig.tag {
case sigRetryerUpdateOutput:
r.out = sig.channel
case sigRetryerOutputAdded:
numOutputs++
case sigRetryerOutputRemoved:
Expand Down

0 comments on commit 041922b

Please sign in to comment.