Skip to content

Commit

Permalink
[CI] Add check-headers and a metadata make goal to simplify the CI (#…
Browse files Browse the repository at this point in the history
  • Loading branch information
v1v authored Jul 27, 2021
1 parent e8ea14b commit 7141820
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 7 deletions.
8 changes: 1 addition & 7 deletions Jenkinsfile
Original file line number Diff line number Diff line change
Expand Up @@ -202,13 +202,7 @@ def runLinting() {
mapParallelTasks["${k}"] = v
}
}
mapParallelTasks['default'] = {
cmd(label: "make check-python", script: "make check-python")
cmd(label: "make notice", script: "make notice")
// `make check-go` must follow `make notice` to ensure that the lint checks can be satisfied
cmd(label: "make check-go", script: "make check-go")
cmd(label: "Check for changes", script: "make check-no-changes")
}
mapParallelTasks['default'] = { cmd(label: 'make check-default', script: 'make check-default') }

parallel(mapParallelTasks)
}
Expand Down
10 changes: 10 additions & 0 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,16 @@ check:
@$(MAKE) check-go
@$(MAKE) check-no-changes

## check : Run some checks similar to what the default check validation runs in the CI.
.PHONY: check-default
check-default:
@$(MAKE) check-python
@echo "The update goal is skipped to speed up the checks in the CI on a PR basis."
@$(MAKE) notice
@$(MAKE) check-headers
@$(MAKE) check-go
@$(MAKE) check-no-changes

## ccheck-go : Check there is no changes in Go modules.
.PHONY: check-go
check-go:
Expand Down

0 comments on commit 7141820

Please sign in to comment.