Skip to content

Commit

Permalink
[Filebeat][httpjson] Adds oauth2 support for httpjson input (#18892)
Browse files Browse the repository at this point in the history
* Filebeat HTTPJSON input initial changes to support oauth2 client_credentials

* [Filebeat][httpjson] Add EndpointParams option to oauth config

* Add provider specific settings to oauth httpjson

* Change config as suggested and add config tests

* Add checks for invalid json in google validation

* Add documentation and azure.resource

* Add oauth2 test and update changelog

* Address docs and change new test case into table tests

* Check if oauth2 is enabled in config.Validate and add test

Closes #18415
  • Loading branch information
marc-gr authored Jun 11, 2020
1 parent 79d79bf commit b6cd17c
Show file tree
Hide file tree
Showing 12 changed files with 1,170 additions and 111 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.next.asciidoc
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ https://github.com/elastic/beats/compare/v7.0.0-alpha2...master[Check the HEAD d
- Preserve case of http.request.method. ECS prior to 1.6 specified normalizing to lowercase, which lost information. Affects filesets: apache/access, elasticsearch/audit, iis/access, iis/error, nginx/access, nginx/ingress_controller, aws/elb, suricata/eve, zeek/http. {issue}18154[18154] {pull}18359[18359]
- Adds check on `<no value>` config option value for the azure input `resource_manager_endpoint`. {pull}18890[18890]
- Okta module now requires objects instead of JSON strings for the `http_headers`, `http_request_body`, `pagination`, `rate_limit`, and `ssl` variables. {pull}18953[18953]
- Adds oauth support for httpjson input. {issue}18415[18415] {pull}18892[18892]

*Heartbeat*

Expand Down
238 changes: 238 additions & 0 deletions vendor/golang.org/x/oauth2/endpoints/endpoints.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions vendor/modules.txt
Original file line number Diff line number Diff line change
Expand Up @@ -947,6 +947,7 @@ golang.org/x/net/websocket
# golang.org/x/oauth2 v0.0.0-20200107190931-bf48bf16ab8d
golang.org/x/oauth2
golang.org/x/oauth2/clientcredentials
golang.org/x/oauth2/endpoints
golang.org/x/oauth2/google
golang.org/x/oauth2/internal
golang.org/x/oauth2/jws
Expand Down
127 changes: 127 additions & 0 deletions x-pack/filebeat/docs/inputs/input-httpjson.asciidoc
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,29 @@ Example configurations:
url: http://localhost:9200/_search/scroll
----

Additionally, it supports authentication via HTTP Headers, API key or oauth2.

Example configurations with authentication:

["source","yaml",subs="attributes"]
----
{beatname_lc}.inputs:
- type: httpjson
http_headers:
Authorization: 'Basic aGVsbG86d29ybGQ='
url: http://localhost
----

["source","yaml",subs="attributes"]
----
{beatname_lc}.inputs:
- type: httpjson
oauth2:
client.id: 12345678901234567890abcdef
client.secret: abcdef12345678901234567890
token_url: http://localhost/oauth2/token
url: http://localhost
----

==== Configuration options

Expand Down Expand Up @@ -249,6 +272,110 @@ information.

The URL of the HTTP API. Required.

[float]
==== `oauth2.enabled`

The `enabled` setting can be used to disable the oauth2 configuration by
setting it to `false`. The default value is `true`.

NOTE: OAuth2 settings are disabled if either `enabled` is set to `false` or
the `oauth2` section is missing.

[float]
==== `oauth2.provider`

The `provider` setting can be used to configure supported oauth2 providers.
Each supported provider will require specific settings. It is not set by default.
Supported providers are: `azure`, `google`.

[float]
==== `oauth2.client.id`

The `client.id` setting is used as part of the authentication flow. It is always required
except if using `google` as provider. Required for providers: `default`, `azure`.

[float]
==== `oauth2.client.secret`

The `client.secret` setting is used as part of the authentication flow. It is always required
except if using `google` as provider. Required for providers: `default`, `azure`.

[float]
==== `oauth2.scopes`

The `scopes` setting defines a list of scopes that will be requested during the oauth2 flow.
It is optional for all providers.

[float]
==== `oauth2.token_url`

The `token_url` setting specifies the endpoint that will be used to generate the
tokens during the oauth2 flow. It is required if no provider is specified.

NOTE: For `azure` provider either `token_url` or `azure.tenant_id` is required.

[float]
==== `oauth2.endpoint_params`

The `endpoint_params` setting specifies a set of values that will be sent on each
request to the `token_url`. Each param key can have multiple values.
Can be set for all providers except `google`.

["source","yaml",subs="attributes"]
----
- type: httpjson
oauth2:
endpoint_params:
Param1:
- ValueA
- ValueB
Param2:
- Value
----

[float]
==== `oauth2.azure.tenant_id`

The `azure.tenant_id` is used for authentication when using `azure` provider.
Since it is used in the process to generate the `token_url`, it can't be used in
combination with it. It is not required.

For information about where to find it, you can refer to
https://docs.microsoft.com/en-us/azure/active-directory/develop/howto-create-service-principal-portal.

[float]
==== `oauth2.azure.resource`

The `azure.resource` is used to identify the accessed WebAPI resource when using `azure` provider.
It is not required.

[float]
==== `oauth2.google.credentials_file`

The `google.credentials_file` setting specifies the credentials file for Google.

NOTE: Only one of the credentials settings can be set at once. If none is provided, loading
default credentials from the environment will be attempted via ADC. For more information about
how to provide Google credentials, please refer to https://cloud.google.com/docs/authentication.

[float]
==== `oauth2.google.credentials_json`

The `google.credentials_json` setting allows to write your credentials information as raw JSON.

NOTE: Only one of the credentials settings can be set at once. If none is provided, loading
default credentials from the environment will be attempted via ADC. For more information about
how to provide Google credentials, please refer to https://cloud.google.com/docs/authentication.

[float]
==== `oauth2.google.jwt_file`

The `google.jwt_file` setting specifies the JWT Account Key file for Google.

NOTE: Only one of the credentials settings can be set at once. If none is provided, loading
default credentials from the environment will be attempted via ADC. For more information about
how to provide Google credentials, please refer to https://cloud.google.com/docs/authentication.

[id="{beatname_lc}-input-{type}-common-options"]
include::../../../../filebeat/docs/inputs/input-common-options.asciidoc[]

Expand Down
Loading

0 comments on commit b6cd17c

Please sign in to comment.