Skip to content

Commit

Permalink
Skip publisher flaky tests (#21657)
Browse files Browse the repository at this point in the history
  • Loading branch information
jsoriano authored Oct 8, 2020
1 parent d5e89d9 commit df03add
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 3 deletions.
8 changes: 5 additions & 3 deletions libbeat/publisher/pipeline/controller_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,8 @@ import (
"github.com/elastic/beats/v7/libbeat/publisher"
"github.com/elastic/beats/v7/libbeat/publisher/queue"
"github.com/elastic/beats/v7/libbeat/publisher/queue/memqueue"
"github.com/elastic/beats/v7/libbeat/tests/resources"

//"github.com/elastic/beats/v7/libbeat/tests/resources"

"github.com/stretchr/testify/require"
)
Expand All @@ -46,8 +47,9 @@ func TestOutputReload(t *testing.T) {
t.Run(name, func(t *testing.T) {
testutil.SeedPRNG(t)

goroutines := resources.NewGoroutinesChecker()
defer goroutines.Check(t)
// Flaky check: https://github.com/elastic/beats/issues/21656
//goroutines := resources.NewGoroutinesChecker()
//defer goroutines.Check(t)

err := quick.Check(func(q uint) bool {
numEventsToPublish := 15000 + (q % 500) // 15000 to 19999
Expand Down
2 changes: 2 additions & 0 deletions libbeat/publisher/pipeline/output_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,8 @@ func TestMakeClientWorker(t *testing.T) {
}

func TestReplaceClientWorker(t *testing.T) {
t.Skip("Flaky test: https://github.com/elastic/beats/issues/17965")

tests := map[string]func(mockPublishFn) outputs.Client{
"client": newMockClient,
"network_client": newMockNetworkClient,
Expand Down

0 comments on commit df03add

Please sign in to comment.