Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ECS] 7.0.0-rc1 Broken Beats Dashboards #11517

Closed
EthanStrider opened this issue Mar 28, 2019 · 17 comments
Closed

[ECS] 7.0.0-rc1 Broken Beats Dashboards #11517

EthanStrider opened this issue Mar 28, 2019 · 17 comments
Assignees
Labels
bug ecs Team:Integrations Label for the Integrations team

Comments

@EthanStrider
Copy link

EthanStrider commented Mar 28, 2019

Certain Beats dashboards appear to be broken by ECS changes since they still reference the old data field names.

Screen Shot 2019-03-28 at 10 06 43 AM

Screen Shot 2019-03-28 at 1 24 14 PM

Screen Shot 2019-03-28 at 1 26 40 PM

Screen Shot 2019-03-28 at 1 26 33 PM

Screen Shot 2019-03-28 at 1 41 46 PM

Screen Shot 2019-03-28 at 1 45 28 PM

Screen Shot 2019-03-28 at 1 52 16 PM

There are probably more... I'll update this ticket as I find them.

For confirmed bugs, please report:

  • Version: 7.0.0-rc1
  • Operating System: Cloud
@EthanStrider
Copy link
Author

Ok, seems like there are a lot of broken dashboards. I'm thinking about writing a script to search all the old terms against this repo: https://github.com/elastic/kibana/tree/7.0/x-pack/plugins/ml/server/models/data_recognizer/modules

@ruflin
Copy link
Member

ruflin commented Mar 28, 2019

For the Beats dashboards we were running this script to migrate the fields: https://github.com/elastic/beats/blob/master/script/kibana-migration.py That should also work for the ML dashboards. But the dashboards you link above, are these from ML or the ones loaded through Beats?

@ruflin ruflin added bug Team:Integrations Label for the Integrations team labels Mar 28, 2019
@EthanStrider
Copy link
Author

@ruflin I think it's a combination of ML dashboards and dashboards loaded through Beats. I'm working on upgrading the demo.elastic.co demo environment, so we use everything.

@EthanStrider
Copy link
Author

From the docs here: https://www.elastic.co/guide/en/beats/libbeat/7.0/breaking-changes-7.0.html

Isn't this backwards?

Shouldn't it be:

auditd.message_type --> event.type

Screen Shot 2019-03-28 at 3 02 26 PM

@fearful-symmetry
Copy link
Contributor

Yah, auditd.message_type seems backwards.

So, I'm just gonna preface this by saying I have almost no experience with the kibana side of things, but I'm trying to learn. That being said, I'm looking at the nginx dashboards, and it looks like a few fields weren't hit by #9998.

From what I can tell, the script will only change names if alias: True which isn't the case for a lot of the user agent fields in ecs-migration.yml

alias: false

This might be why a lot of the visualizations that rely on user_agent are using the pre-ecs fields:

"field": "nginx.access.user_agent.os_major",

that should be user_agent.os.version for ecs?

I wonder if this is a case where we need to start changing dashboards by hand.

@EthanStrider
Copy link
Author

EthanStrider commented Mar 28, 2019

that should be user_agent.os.version for ecs?

Yes, that is correct.

@EthanStrider
Copy link
Author

Created a PR here: #11520

@ruflin
Copy link
Member

ruflin commented Mar 29, 2019

@EthanStrider As #11520 is closed, I think we can close this issue.

@fearful-symmetry Could you do some test checks if we miss some more fields which don't have an alias? I thought I did but seems like I missed some :-(

@EthanStrider
Copy link
Author

EthanStrider commented Mar 29, 2019

@ruflin Thanks! Is there going to be an updated build for 7.0.0-rc1?
https://staging.elastic.co/7.0.0-rc1-2fe9f018/summary-7.0.0-rc1.html

I'm not sure how the build system works, but I'd like to grab the docker image for Filebeat 7.0.0-rc1 with the latest fixes.

@webmat
Copy link
Contributor

webmat commented Mar 29, 2019

@EthanStrider For the event.type change, I know it looks backwards, but this is actually expected.

event.type will come back with a very well defined set of values that need to be used across all sources. So whatever was in there, populated by prior versions of Auditbeat's auditd module is being moved to a custom field now.

cc @fearful-symmetry

@ruflin
Copy link
Member

ruflin commented Mar 29, 2019

@webmat So the change in this PR to event.type should be reverted? I'm now also confused :-)

@webmat
Copy link
Contributor

webmat commented Mar 29, 2019

event.type right now is reserved. Must not be used in 7.0.

Still going through the PR, but yes, it needs to be made auditd.event_type again

@EthanStrider
Copy link
Author

@ruflin Sounds like just the change to the doc needs to be reverted. I added a comment.

@fearful-symmetry
Copy link
Contributor

Trying to track where we are with this. We have
#11520
Related, #11538
#11545

I think those PRs should cover everything?

@webmat
Copy link
Contributor

webmat commented Apr 1, 2019

As far as I know, everything here has been addressed.

WDYT @EthanStrider?

@EthanStrider
Copy link
Author

Looks good! If I find anything else, I'll let you know.

@ruflin
Copy link
Member

ruflin commented Apr 2, 2019

Thanks everyone, closing this for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug ecs Team:Integrations Label for the Integrations team
Projects
None yet
Development

No branches or pull requests

6 participants