Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Filebeat ECS dashboards #11520

Merged
merged 2 commits into from
Mar 29, 2019

Conversation

EthanStrider
Copy link

No description provided.

@EthanStrider EthanStrider requested a review from a team as a code owner March 29, 2019 03:30
@@ -28,7 +28,7 @@
"id": "1",
"params": {
"customLabel": "Query time",
"field": "mysql.slowlog.query_time.sec"
"field": "event.duration"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one changes the unit, so it's not a 1-1 mapping. We should follow up to see if the dashboard still looks as expected.

@@ -40,7 +40,7 @@
"enabled": true,
"id": "3",
"params": {
"field": "nginx.access.remote_ip",
"field": "source.address",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't find this on in our ecs migration list. Seems like we missed this one.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was the main reason for #11512. You'll see it when it's backported ;-)

@ruflin
Copy link
Member

ruflin commented Mar 29, 2019

I wonder why these didn't get properly renamed. Perhaps we touched these after the rename?

@ruflin
Copy link
Member

ruflin commented Mar 29, 2019

@EthanStrider Thanks for the fix and digging into this. Will forward port it to master.

@ruflin ruflin added bug Filebeat Filebeat labels Mar 29, 2019
@EthanStrider
Copy link
Author

Thanks!
Related: #11512

@ruflin
Copy link
Member

ruflin commented Mar 29, 2019

Yep, also merged this one and will backport to 7.0 now. Let me know if you find any other broken dashboards.

ruflin pushed a commit to ruflin/beats that referenced this pull request Mar 29, 2019
@@ -2,6 +2,7 @@
[frame="topbot",options="header"]
|======================
|Old Field|New Field
|`auditd.message_type` |`event.type`
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@webmat Do we need to revert this change?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it should :-)

@@ -12,7 +13,6 @@
|`docker.container.image` |`container.image.name`
|`docker.container.labels` |`container.labels`
|`docker.container.name` |`container.name`
|`event.type` |`auditd.message_type`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be put back as it was. event.type is reserved and should not be used in 7.0

@webmat webmat added the ecs label Mar 29, 2019
ruflin added a commit that referenced this pull request Mar 29, 2019
* Fixed Filebeat ECS dashboards (#11520)

(cherry picked from commit 32e6378)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants