Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Metricbeat] standardize checks of r.Event inside loops #11828

Closed
4 of 17 tasks
fearful-symmetry opened this issue Apr 15, 2019 · 0 comments
Closed
4 of 17 tasks

[Metricbeat] standardize checks of r.Event inside loops #11828

fearful-symmetry opened this issue Apr 15, 2019 · 0 comments
Assignees
Labels
meta Metricbeat Metricbeat Team:Integrations Label for the Integrations team

Comments

@fearful-symmetry
Copy link
Contributor

fearful-symmetry commented Apr 15, 2019

This is a more specific continuation of #11666
It looks like the best way to handle calling r.Event inside a loop is to check the bool return value, and just return from Fetch if we get a false. This will only happen when the metricset is closed. This obviously isn't a huge issue, but it would be nice to standardize how we handle this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Metricbeat Metricbeat Team:Integrations Label for the Integrations team
Projects
None yet
Development

No branches or pull requests

2 participants