[metricbeat] migrate kafka to reporterV2 with error return #11868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fearful-symmetry
added
Metricbeat
17 tasks
93 tasks
ruflin
approved these changes
Apr 23, 2019
exekias
reviewed
Apr 23, 2019
| ModuleFields: common.MapStr{ | ||
| "broker": evtBroker, | ||
| "topic": evtTopic, | ||
| }, | ||
| MetricSetFields: event, | ||
| }) | ||
| if !sent { | ||
| return errors.New("metricset is closed") |
There was a problem hiding this comment.
Should we report an error here? I understood this is false when the metricset is stopped, which is not an error but a known condition
There was a problem hiding this comment.
Yah. In theory you don't need to return an error, but for whatever reason return nil just seemed...weird here.
There was a problem hiding this comment.
We should return nil here, yes. If you want you can log something like "Fetch interrupted, metricset stopping" at the debug level.
kaiyan-sheng
approved these changes
Apr 23, 2019
exekias
approved these changes
Apr 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #11374
For whatever reason, I couldn't get the integration tests working on OSX. Took me a while to get a proper beats env setup on my linux box.