Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Metricbeat kubernetes.container.cpu.limit.cores data type #11975

Closed
evilezh opened this issue Apr 29, 2019 · 4 comments · Fixed by #12476
Closed

Metricbeat kubernetes.container.cpu.limit.cores data type #11975

evilezh opened this issue Apr 29, 2019 · 4 comments · Fixed by #12476
Labels
bug containers Related to containers use case good first issue Indicates a good issue for first-time contributors Metricbeat Metricbeat module Team:Integrations Label for the Integrations team

Comments

@evilezh
Copy link

evilezh commented Apr 29, 2019

kubernetes.container.cpu.limit.cores field shall be some kind of float rather than long. It is possible to have 0.1 core as it is recorded in elasticsearch. If type is long and we do aggs, then 0.x is interpreted as 0, which is wrong.
@exekias exekias added Team:Integrations Label for the Integrations team bug containers Related to containers use case Metricbeat Metricbeat labels Apr 29, 2019
@exekias
Copy link
Contributor

exekias commented Apr 29, 2019

This sounds about right, we should change their type to support these values

@exekias exekias added module good first issue Indicates a good issue for first-time contributors low hanging fruit and removed good first issue Indicates a good issue for first-time contributors labels Apr 29, 2019
@evilezh
Copy link
Author

evilezh commented Apr 29, 2019

I just went through more fields. There is more .cores fields which are also long.
Maybe just review all of them.
I think nanocores was replaced with cores and second, shall be with decimal places. e.g. nano to full core conversion.

@kaiyan-sheng
Copy link
Contributor

Right now in kubernetes module, we have cpu.usage.core.ns and cpu.usage.nanocores. These numbers are relatively large so do we still need to change the field type from long to double to preserve the decimals?

@exekias
Copy link
Contributor

exekias commented May 2, 2019

I think those are ok as long, they don't have decimals, or we can ignore them

@easkay easkay mentioned this issue Jun 7, 2019
Merged
@zube zube bot added [zube]: Done and removed [zube]: Ready labels Jun 7, 2019
exekias pushed a commit that referenced this issue Jun 7, 2019
@easkay
Fix 11975 - change Kubernetes container cpu cores fields to float (#1…
8502c79 
…2476)

* Fix 11975 kubernetes cores fields data type long -> float (#11975)

kubernetes.container.cpu.limit.cores is now a float
kubernetes.container.cpu.request.cores is now a float
andrewvc pushed a commit to andrewvc/beats that referenced this issue Jun 12, 2019
@easkay @andrewvc
Fix 11975 - change Kubernetes container cpu cores fields to float (el…
89cab2f 
…astic#12476)

* Fix 11975 kubernetes cores fields data type long -> float (elastic#11975)

kubernetes.container.cpu.limit.cores is now a float
kubernetes.container.cpu.request.cores is now a float
exekias pushed a commit to exekias/beats that referenced this issue Jun 19, 2019
@easkay
Fix 11975 - change Kubernetes container cpu cores fields to float (el…
852eaef 
…astic#12476)

* Fix 11975 kubernetes cores fields data type long -> float (elastic#11975)

kubernetes.container.cpu.limit.cores is now a float
kubernetes.container.cpu.request.cores is now a float

(cherry picked from commit 8502c79)
@exekias exekias mentioned this issue Jun 19, 2019
Merged
exekias pushed a commit that referenced this issue Jun 20, 2019
Cherry-pick #12476 to 7.2: Fix 11975 - change Kubernetes container cp…
9ba65d8 
…u cores fields to float (#12609)

* Fix 11975 - change Kubernetes container cpu cores fields to float (#12476)

* Fix 11975 kubernetes cores fields data type long -> float (#11975)

kubernetes.container.cpu.limit.cores is now a float
kubernetes.container.cpu.request.cores is now a float

(cherry picked from commit 8502c79)

* Update CHANGELOG.next.asciidoc
@andresrc andresrc added the good first issue Indicates a good issue for first-time contributors label Mar 25, 2020
leweafan pushed a commit to leweafan/beats that referenced this issue Apr 28, 2023
Cherry-pick elastic#12476 to 7.2: Fix 11975 - change Kubernetes conta…
fcba692 
…iner cpu cores fields to float (elastic#12609)

* Fix 11975 - change Kubernetes container cpu cores fields to float (elastic#12476)

* Fix 11975 kubernetes cores fields data type long -> float (elastic#11975)

kubernetes.container.cpu.limit.cores is now a float
kubernetes.container.cpu.request.cores is now a float

(cherry picked from commit d8eb8e8)

* Update CHANGELOG.next.asciidoc
@ali786XI ali786XI mentioned this issue Feb 12, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug containers Related to containers use case good first issue Indicates a good issue for first-time contributors Metricbeat Metricbeat module Team:Integrations Label for the Integrations team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix 11975 - change Kubernetes container cpu cores fields to float
5 participants
@exekias @andresrc @evilezh @kaiyan-sheng @alvarolobato