Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Heartbeat] host.name should not be set in heartbeat #12107

Closed
andrewvc opened this issue May 8, 2019 · 2 comments · Fixed by #14140
Closed

[Heartbeat] host.name should not be set in heartbeat #12107

andrewvc opened this issue May 8, 2019 · 2 comments · Fixed by #14140
Assignees
@shahzad31
Labels
bug Heartbeat Team:obs-ds-hosted-services Label for the Observability Hosted Services team test-plan Add this PR to be manual test plan test-plan-ok This PR passed manual testing v7.6.0

Comments

@andrewvc
Copy link
Contributor

andrewvc commented May 8, 2019

libbeat still sets host.name on all events even with the add_host_metadata processor removed. We should remove it, as heartbeat is an observer not a host in ECS parlance. There is prior art here in APM.
@andrewvc andrewvc added bug Heartbeat Team:obs-ds-hosted-services Label for the Observability Hosted Services team labels May 8, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/uptime

@skh skh mentioned this issue May 9, 2019
Merged
4 tasks
@MikePaquette MikePaquette mentioned this issue Jul 19, 2019
Closed
8 tasks
@fgabolde fgabolde mentioned this issue Sep 24, 2019
Closed
@andrewvc andrewvc assigned andrewvc and unassigned andrewvc Oct 17, 2019
andrewvc added a commit to andrewvc/beats that referenced this issue Oct 18, 2019
@andrewvc
[Heartbeat] Remove host.name field from events
9dfae6e 
This field should never have been present, and is a distraction from the
observer.* fields.

Resolves elastic#12107
@andrewvc andrewvc mentioned this issue Oct 18, 2019
Merged
andrewvc added a commit that referenced this issue Oct 22, 2019
@andrewvc
[Heartbeat] Remove host.name field from events (#14140)
dd2c9ee 
This field should never have been present, and is a distraction from the
observer.* fields.

Resolves #12107
@andrewvc andrewvc added the test-plan Add this PR to be manual test plan label Jan 16, 2020
@shahzad31 shahzad31 self-assigned this Jan 20, 2020
@shahzad31
Copy link
Contributor

Testing for release 7.6.0
Ran heatbeat 7.5 and i can see host.name field

image

Ran heartbeat 7.6.0 and it doesn't contains host.name field.
Ran heartbeat 8.0.0 and it doesn't contains host.name field.

@shahzad31 shahzad31 added the test-plan-ok This PR passed manual testing label Jan 20, 2020
@sayden sayden mentioned this issue May 4, 2020
Closed
jorgemarey pushed a commit to jorgemarey/beats that referenced this issue Jun 8, 2020
@andrewvc @jorgemarey
[Heartbeat] Remove host.name field from events (elastic#14140)
f1f423b 
This field should never have been present, and is a distraction from the
observer.* fields.

Resolves elastic#12107
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shahzad31 shahzad31

Labels
bug Heartbeat Team:obs-ds-hosted-services Label for the Observability Hosted Services team test-plan Add this PR to be manual test plan test-plan-ok This PR passed manual testing v7.6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Heartbeat] Remove host.name field from events andrewvc/beats
3 participants
@andrewvc @shahzad31 @elasticmachine