Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements in metricbeat modules integration tests #12909

Closed
6 tasks done
jsoriano opened this issue Jul 15, 2019 · 1 comment
Closed
6 tasks done

Improvements in metricbeat modules integration tests #12909

jsoriano opened this issue Jul 15, 2019 · 1 comment
Assignees
Labels
meta Team:Integrations Label for the Integrations team :Testing

Comments

@jsoriano
Copy link
Member

jsoriano commented Jul 15, 2019

Introduce some improvements in metricbeat modules integration tests to make them easier to run and parallelize.

This meta issue is intended to introduce changes tested in #7957 piece by piece.

Related changes for python system tests were already introduced in #11925.

@jsoriano jsoriano self-assigned this Jul 15, 2019
@exekias exekias added the Team:Integrations Label for the Integrations team label Jul 15, 2019
jsoriano added a commit to jsoriano/beats that referenced this issue Sep 25, 2019
Fix image names so they can be more easily reused, cached and shared.

Modify all Dockerfiles related to metricbeat resources to parameterize
their versions.

Build args are not used anymore in docker compose, and environment is
used instead. The reason is that build args couldn't be used to tag
the images. Build args are still passed to Dockerfiles, and they don't
have default values now, they must be set in the docker compose file.

Some services that are being tested with multiple versions have been
refactorized to be parameterized so they can share most of their
Dockerfiles and docker compose definitions.

Part of elastic#13471 and elastic#12909.
jsoriano added a commit that referenced this issue Oct 1, 2019
Tag image names so they can be more easily reused, cached and shared.

Modify all Dockerfiles related to metricbeat resources to parameterize
their versions.

Build args are not used anymore in docker compose, and environment is
used instead. The reason is that build args couldn't be used to tag
the images. Build args are still passed to Dockerfiles, and they don't
have default values now, they must be set in the docker compose file.

Some services that are being tested with multiple versions have been
refactorized to be parameterized so they can share most of their
Dockerfiles and docker compose definitions.

Testing framework doesn't force rebuild of images now. If an image
exists with the same tag this image will be used. Before trying to start
a service, it tries to pull its image to avoid building it if it is available.
Both pull and build will reuse local layers if they can.

Part of #13471 and #12909.
@jsoriano
Copy link
Member Author

Closing this, everything was done except some parts of #14606 that can be done incrementally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Team:Integrations Label for the Integrations team :Testing
Projects
None yet
Development

No branches or pull requests

3 participants