Dedotting by default is not working on metricbeat Kubernetes module

[jsoriano]

In Beats 6.7 we introduced dedotting options to all known places where dedotting could be needed for labels and annotations, and in 7.0 we set these options to true by default, so dedotting is done unless otherwise wanted (see #9860).

This is not working for metricbeat Kubernetes module, where at least labels collected by the container metricset are not dedotted.

I think that the problem is how we initialize the meta generator in the metadata enricher, there we do:

        metaConfig := kubernetes.MetaGeneratorConfig{}
        if err := base.Module().UnpackConfig(&metaConfig); err != nil {
                logp.Err("Error initializing Kubernetes metadata enricher: %s", err)
                return &nilEnricher{}
        }

        metaGen := kubernetes.NewMetaGeneratorFromConfig(&metaConfig)

So metaConfig has an empty configuration. We should have a kubernetes.DefaultMetaGeneratorConfig() that generates a default configuration, and use it any time we initialize configurations of this type.

func DefaultMetaGeneratorConfig() MetaGeneratorConfig {
    return MetaGeneratorConfig {
                IncludeCreatorMetadata: true,
                LabelsDedot:            true,
                AnnotationsDedot:       true,
    }
} 

Not sure if IncludeCreatorMetadata is also wanted, but it is enabled by default in kubernetes.NewMetaGenerator.

For confirmed bugs, please report:

• Version: 7.x
• Steps to Reproduce: Use the kubernetes module with containers with dots in their labels