Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dedot Kubernetes labels and annotations #9860

Closed
3 tasks done
exekias opened this issue Jan 3, 2019 · 3 comments · Fixed by #9939
Closed
3 tasks done

Dedot Kubernetes labels and annotations #9860

exekias opened this issue Jan 3, 2019 · 3 comments · Fixed by #9939
Assignees
@kaiyan-sheng
Labels
containers Related to containers use case enhancement libbeat Metricbeat Metricbeat Team:Integrations Label for the Integrations team v6.7.0 v7.0.0-beta1

Comments

@exekias
Copy link
Contributor

exekias commented Jan 3, 2019 •
edited by kaiyan-sheng
Loading

Dots in Kubernetes labels/annotations can lead to mapping issues (see #8773).

We want to transition to automatically "dedotting" both labels & annotations by introducing the labels.dedot setting in 6.x and enable it by default in 7.0. Similar to #9505

Kubernetes labels & annotations can be found in:

  • Metricbeat Kubernetes module
  • Libbeat autodiscover provider
  • Libbeat add_kubernetes_metadata processor

closes #8773
@exekias exekias added enhancement libbeat Metricbeat Metricbeat containers Related to containers use case Team:Integrations Label for the Integrations team labels Jan 3, 2019
@exekias exekias mentioned this issue Jan 3, 2019
Closed
@kaiyan-sheng
Copy link
Contributor

Should this be a subtask in #9501 ?

@kaiyan-sheng kaiyan-sheng mentioned this issue Jan 4, 2019
Closed
2 tasks
@exekias
Copy link
Contributor Author

exekias commented Jan 4, 2019

yes! I have added it to the list, thank you!

@kaiyan-sheng kaiyan-sheng self-assigned this Jan 7, 2019
@kaiyan-sheng kaiyan-sheng mentioned this issue Jan 8, 2019
Merged
@pichouk pichouk mentioned this issue Mar 21, 2019
Closed
@pichouk pichouk mentioned this issue Apr 29, 2019
Closed
@morganchristiansson
Copy link

morganchristiansson commented Jun 10, 2019 •
edited
Loading

It seems like the PR that closed this issue was for add_kubernetes_metadata however metricbeat kubernetes module still doesn't support dedotting?

It's enabled by default in the stable helm chart and is breaking if there are labels with dots.

EDIT: nevermind it works after adding:

          labels.dedot: true
          annotations.dedot: true

@jsoriano jsoriano mentioned this issue Aug 29, 2019
Closed
@Kilz78 Kilz78 mentioned this issue Jul 27, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kaiyan-sheng kaiyan-sheng

Labels
containers Related to containers use case enhancement libbeat Metricbeat Metricbeat Team:Integrations Label for the Integrations team v6.7.0 v7.0.0-beta1
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Dedot for Kubernetes labels and annotations
3 participants
@morganchristiansson @exekias @kaiyan-sheng