Add Dedot for Kubernetes labels and annotations

[kaiyan-sheng]

Adding labels.dedot and annotations.dedot in kubernetes metricbeat config file to control dedot.
closes #9860

[exekias]

This change is looking good! There are some other places where Kubernetes metadata is generated, they can be tackled here or in a different PR (maybe this is better):

Autodiscover, add_kubernetes_metadata and the rest of Metricbeat kubernetes metricsets make use of the metadata generator: https://github.com/elastic/beats/blob/master/libbeat/common/kubernetes/metadata.go

[exekias]

This is good on my side, WDYT @urso ?

[urso]

LGTM.

small 'generic' nit: I'd like to advocate for short descriptive names. E.g. generateMapStrFromEvent could be shortened to genMapStrFromEvent, eventToMapStr, mapstrFromEvent, makeFields, genFields, or genMapStr ;)

[anton-johansson]

This is 100% the wrong place to ask this, but I couldn't find any official information about it. I'm assuming this feature will be included in 6.7.x. Is there any place I can find release dates for this?

[ruflin]

This will land in 6.7 but we don't publish any release dates.

[anton-johansson]

Okay, thanks @ruflin.

I have a question regarding #6203. This seems to have done something related to dedotting Kubernetes data as well. What's the difference between these two PR's? Which one does what? The other one is around a year old.

[ruflin]

@anton-johansson Let's move this discussion to discuss: https://discuss.elastic.co/c/beats

[anton-johansson]

Okay, fair point! I will post a topic about it.

The topic can be found here.

[willejs]

@ruflin there wasnt a reply on the beats discussion, and i am too wondering when this will be released? Can you cut a 6.7 release?

[ruflin]

A 6.7 release is coming in the near future. If you want to be a bit more adventurous and try out the master build, you can find snapshots here: https://beats-ci.elastic.co/job/elastic+beats+master+multijob-package-linux/398/gcsObjects/

@anton-johansson Sorry that we missed your discuss topic :-(

[willejs]

@ruflin Thanks for the response!
Is there a documented or commonly understood release process for beats? or is it just as and when? I just want to understand when it might happen, or under what circumstances, and if I can influence it in any way? It might help shed some light for others too asking about this.

[anton-johansson]

@ruflin: No worries! Technically, you had nothing to answer with, since there's no news. ¯\_(ツ)_/¯ Thanks for getting back to us!

Yeah, it would be great with some kind of announced schedule or plan for atleast the upcoming release. I could try the master build, but it would depend on how far away this near future is. :D

[ruflin]

I can't provide you with a schedule but I could provide you with a snapshot build of 7.0 if you let me know the platform and beat you are looking for.

[willejs]

@ruflin Thanks for the offer, but I cant really run snapshot builds in production. How do you decide to cut release 6.7? Could you not make this whole process transparent and automated in CI/CD? I am willing to help in any way do that!

I keep asking because I need to decide if I just fork this for now, set up CI/CD, and build 6.7 and push a docker container to our private registry. Thats a couple hours work, and lots of people will disapprove of me doing so! At that point I might as well just use a snapshot build...

[ruflin]

All of the Elastic Stack is released together which includes a lot of manual testing which takes time. If you want to build a snapshot on your own, I recommend to do it based the 6.7 branch if that is the version you are looking for: https://github.com/elastic/beats/tree/6.7 This is mostly what should be released.

[anton-johansson]

@willejs, 6.7.0 was just released, FYI.