Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow up: reduce memory usage with MapStr formatting #15653

Closed
ycombinator opened this issue Jan 17, 2020 · 1 comment
Closed

Follow up: reduce memory usage with MapStr formatting #15653

ycombinator opened this issue Jan 17, 2020 · 1 comment
Labels
libbeat Stalled Team:Integrations Label for the Integrations team

Comments

@ycombinator
Copy link
Contributor

In #15616 we implemented masking of sensitive fields in common.MapStr objects. This implementation relies on cloning the object so masks may applied to the clone while preserving the original as-is.

Depending on the size of the object being cloned, the cloning could be expensive in terms of memory allocations. Ideally we could replace this implementation with a streaming one, perhaps using https://github.com/elastic/go-structform, to save on memory allocations. The masking would be done via a transformer on the stream.

@botelastic
Copy link

botelastic bot commented Feb 4, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@botelastic botelastic bot added the Stalled label Feb 4, 2021
@botelastic botelastic bot closed this as completed Mar 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
libbeat Stalled Team:Integrations Label for the Integrations team
Projects
None yet
Development

No branches or pull requests

2 participants