Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redis output multiple password support. #16058

Closed
urso opened this issue Feb 4, 2020 · 2 comments · Fixed by #16206
Closed

Redis output multiple password support. #16058

urso opened this issue Feb 4, 2020 · 2 comments · Fixed by #16206
Labels
bug enhancement good first issue Indicates a good issue for first-time contributors libbeat :Outputs Team:Integrations Label for the Integrations team

Comments

@urso
Copy link

urso commented Feb 4, 2020

The redis output allows the user to configure multiple redis hosts. Beats will use the list of hosts for load-balancing. The redis output allows users to configure an username and password, but this requires users to setup each redis host with the same set of credentials.

Similar to other outputs and modules in metricbeat the username and password should be configurable with per host like this (proposal by @andrewkroh #5891 (comment)):

hosts:
- user:pass@remote:6379
- localhost:6379
username: default
password: secret
@rvillablanca
Copy link
Contributor

I know that redis only authenticates with password and username is not required, so in the example of the configuration the key username would be invalid right ?

Maybe a valid configuration could be

hosts:
- :pass@remote:6379
- localhost:6379
password: secret

But not sure if for case of remote host is a valid url

@urso
Copy link
Author

urso commented Feb 10, 2020

Right, it is more like a shared secret, and less a full authentication scheme. We can easily remove the : prefix as well.

For reference (Redis Security docs): https://redis.io/topics/security

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug enhancement good first issue Indicates a good issue for first-time contributors libbeat :Outputs Team:Integrations Label for the Integrations team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants