-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using specific pass for each host in redis output #16206
Conversation
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
1 similar comment
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
Thank you for the PR. I wonder if we want to enforce the |
Yeah as I said before, for me it is ok both way but the second one (whithout |
So what will we do with the colon? |
Using The redis output supports connecting to redis via TLS as well. The URL scheme would be You want to give it a try introducing the 'rediss' scheme as well? Or shall follow up later? |
Sure let's do it |
@urso at the moment I am validating that a valid tls configuration is required when using |
If TLS is used the Elasticsearch output itself does not much. The output only configures a TLS dialer. The net/http package will use the TLS dialer if the "https" schema is used. If the user did not explicitely configure TLS, then the dialer will use system (and go net) defaults. The output creates a TCP and TLS dialer first, and assignes those to the http.Transport. If "https" is used net/http will use the TLS DLS dialer we did set up. In case TLS was not configured, then the crypto/tls package will fallback to its default configuration. All in all, it is more a matter of configuring and selecting the correct dialer based on the scheme used. |
* using specific port instead defaultPort when apply * default tls config when ussing 'rediss' scheme
Please add some integration tests as well. Check out |
I made all your suggestions, only integration test remain but I need some time, thanks for your mentoring @urso 👌 |
Before writing integration test I'd like to make sure that they are actually passing so, I suppose I can do that by running |
Running I tried it by running |
Jenkins, test this. |
I had to add the license header manually because every time I have to run some script related with python I have different problems. I really expect the migration to python 3 is finished. We are done with this @urso 👍 |
CI is failing and I still having problems running tasks with python, the message is If I try to configure python with
|
According to this https://www.elastic.co/guide/en/beats/devguide/current/beats-contributing.html migration is done so I will try it again |
Jenkins, test this. |
Approved. I started an internal CI run and will merge + prepare backports to release branches tomorrow. I expect the enhancement to become available with 7.7.0. |
This PR adds support for redis URL schema when configuring the hosts. Each url can have it's own password, overwriting the outputs password setting. The URL scheme used can enable or disable TLS support as well. Using `redis` we always disable TLS, but when using `rediss` TLS will be enabled. (cherry picked from commit 0d31ea2)
This PR adds support for redis URL schema when configuring the hosts. Each url can have it's own password, overwriting the outputs password setting. The URL scheme used can enable or disable TLS support as well. Using `redis` we always disable TLS, but when using `rediss` TLS will be enabled. (cherry picked from commit 0d31ea2) Co-authored-by: Rodrigo Villablanca Vásquez <villa061004@gmail.com>
PR and backports are merged. Thank you for taking the time to improve the redis output! |
What does this PR do?
This PR adds support to redis output for multiple password
Why is it important?
It is useful when you have a multiple redis instances with different credentials.
Checklist
I have commented my code, particularly in hard-to-understand areasI have made corresponding changes to the documentationI have made corresponding change to the default configuration filesRelated issues