-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update redis host settings docs #16518
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The redis host setting accepts passwords and URL schemas by now. This change update the reference config files and docs.
urso
added
docs
review
needs_backport
PR is waiting to be backported to other branches.
v7.7.0
Team:Services
(Deprecated) Label for the former Integrations-Services team
labels
Feb 24, 2020
dedemorton
requested changes
Feb 24, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few editorial changes. Otherwise looks good.
dedemorton
approved these changes
Feb 24, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
2 tasks
urso
removed
the
needs_backport
PR is waiting to be backported to other branches.
label
Feb 25, 2020
urso
pushed a commit
to urso/beats
that referenced
this pull request
Feb 25, 2020
* Update redis host settings docs The redis host setting accepts passwords and URL schemas by now. This change update the reference config files and docs. (cherry picked from commit c4671eb)
urso
pushed a commit
that referenced
this pull request
Feb 28, 2020
* Update redis host settings docs The redis host setting accepts passwords and URL schemas by now. This change update the reference config files and docs. (cherry picked from commit c4671eb)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Output reference config files and redis output docs.
Why is it important?
The redis host setting accepts passwords and URL schemas by now.
This change update the reference config files and docs.
Checklist
- [ ] My code follows the style guidelines of this project- [ ] I have commented my code, particularly in hard-to-understand areas- [ ] I have added tests that prove my fix is effective or that my feature worksRelated issues