Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update redis host settings docs #16518

Merged
merged 2 commits into from
Feb 25, 2020
Merged

Update redis host settings docs #16518

merged 2 commits into from
Feb 25, 2020

Conversation

urso
Copy link

@urso urso commented Feb 24, 2020

  • Doc update

What does this PR do?

Output reference config files and redis output docs.

Why is it important?

The redis host setting accepts passwords and URL schemas by now.
This change update the reference config files and docs.

Checklist

- [ ] My code follows the style guidelines of this project
- [ ] I have commented my code, particularly in hard-to-understand areas

  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
    - [ ] I have added tests that prove my fix is effective or that my feature works

Related issues

The redis host setting accepts passwords and URL schemas by now.
This change update the reference config files and docs.
@urso urso added docs review needs_backport PR is waiting to be backported to other branches. v7.7.0 Team:Services (Deprecated) Label for the former Integrations-Services team labels Feb 24, 2020
@urso urso requested a review from dedemorton February 24, 2020 16:05
@urso urso requested review from a team as code owners February 24, 2020 16:05
Copy link
Contributor

@dedemorton dedemorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few editorial changes. Otherwise looks good.

auditbeat/auditbeat.reference.yml Outdated Show resolved Hide resolved
libbeat/outputs/redis/docs/redis.asciidoc Outdated Show resolved Hide resolved
libbeat/outputs/redis/docs/redis.asciidoc Outdated Show resolved Hide resolved
libbeat/outputs/redis/docs/redis.asciidoc Outdated Show resolved Hide resolved
libbeat/outputs/redis/docs/redis.asciidoc Outdated Show resolved Hide resolved
@urso urso requested a review from dedemorton February 24, 2020 16:59
Copy link
Contributor

@dedemorton dedemorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@urso urso merged commit c4671eb into elastic:master Feb 25, 2020
@urso urso deleted the redis-url-doc branch February 25, 2020 11:58
@urso urso removed the needs_backport PR is waiting to be backported to other branches. label Feb 25, 2020
urso pushed a commit to urso/beats that referenced this pull request Feb 25, 2020
* Update redis host settings docs

The redis host setting accepts passwords and URL schemas by now.
This change update the reference config files and docs.

(cherry picked from commit c4671eb)
urso pushed a commit that referenced this pull request Feb 28, 2020
* Update redis host settings docs

The redis host setting accepts passwords and URL schemas by now.
This change update the reference config files and docs.

(cherry picked from commit c4671eb)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs review Team:Services (Deprecated) Label for the former Integrations-Services team v7.7.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants