Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Beats to Go 1.14 #16566

Closed
4 tasks
kvch opened this issue Feb 25, 2020 · 2 comments · Fixed by #19753
Closed
4 tasks

Update Beats to Go 1.14 #16566

kvch opened this issue Feb 25, 2020 · 2 comments · Fixed by #19753
Assignees
@kvch
Labels
Team:Services (Deprecated) Label for the former Integrations-Services team

Comments

@kvch
Copy link
Contributor

kvch commented Feb 25, 2020 •
edited
Loading

This issue is created to make sure all changes in go modules are addressed.

  • remove configurable -mod=vendor option as Go automatically pick it up
  • follow up changes in Beats generators
  • update version in Dockerfiles
  • update version in .go-version
@kvch kvch added the Team:Services (Deprecated) Label for the former Integrations-Services team label Feb 25, 2020
@kvch kvch self-assigned this Feb 25, 2020
@m1357
Copy link

m1357 commented Mar 27, 2020

This issue still persists and cannot build x-pack mods from source

@lasselj
Copy link
Contributor

lasselj commented May 9, 2020

+1

@blakerouse blakerouse mentioned this issue May 28, 2020
Closed
5 tasks
@kvch kvch mentioned this issue Jul 8, 2020
Merged
6 tasks
kvch added a commit that referenced this issue Jul 9, 2020
@kvch
Update go version to 1.14.4 (#19753)
7580c72 
## What does this PR do?

This PR adds support for Golang 1.14.4 in Beats. The dependency `golang.org/x/tools` is pinned to `release-branch.go1.14`.

The generated Beats no longer contain a vendor folder.

## Why is it important?

Go 1.14 has been out for quite some time. It is high time we update.

## Related issues

Closes #18829
Closes #16566
@kvch kvch mentioned this issue Jul 9, 2020
Merged
6 tasks
kvch added a commit to kvch/beats that referenced this issue Jul 13, 2020
@kvch
Update go version to 1.14.4 (elastic#19753)
5972891 
This PR adds support for Golang 1.14.4 in Beats. The dependency `golang.org/x/tools` is pinned to `release-branch.go1.14`.

The generated Beats no longer contain a vendor folder.

Go 1.14 has been out for quite some time. It is high time we update.

Closes elastic#18829
Closes elastic#16566

(cherry picked from commit 7580c72)
kvch added a commit that referenced this issue Jul 13, 2020
@kvch
Update go version to 1.14.4 (#19753) (#19792)
569e289 
This PR adds support for Golang 1.14.4 in Beats. The dependency `golang.org/x/tools` is pinned to `release-branch.go1.14`.

The generated Beats no longer contain a vendor folder.

Go 1.14 has been out for quite some time. It is high time we update.

Closes #18829
Closes #16566

(cherry picked from commit 7580c72)
melchiormoulin pushed a commit to melchiormoulin/beats that referenced this issue Oct 14, 2020
@kvch @melchiormoulin
Update go version to 1.14.4 (elastic#19753)
29f1c44 
## What does this PR do?

This PR adds support for Golang 1.14.4 in Beats. The dependency `golang.org/x/tools` is pinned to `release-branch.go1.14`.

The generated Beats no longer contain a vendor folder.

## Why is it important?

Go 1.14 has been out for quite some time. It is high time we update.

## Related issues

Closes elastic#18829
Closes elastic#16566
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kvch kvch

Labels
Team:Services (Deprecated) Label for the former Integrations-Services team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update go version to 1.14.4 kvch/beats
Update go version to go 1.14.3 blakerouse/beats
5 participants
@urso @andresrc @kvch @lasselj @m1357