Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation improvement for creating your own beat #24660

Closed
robb3rt opened this issue Mar 20, 2021 · 1 comment · Fixed by #24944
Closed

Documentation improvement for creating your own beat #24660

robb3rt opened this issue Mar 20, 2021 · 1 comment · Fixed by #24944
Labels
docs libbeat Team:Docs Label for the Observability docs team

Comments

@robb3rt
Copy link

robb3rt commented Mar 20, 2021

Describe the enhancement:
docs/devguide/newbeat.asciidoc
Improve documentation around creating custom beats. Specifically, using make setup as described in our documentation here (relevant Github file) causes an error:

pi@pitest:~/go/src/github.com/robb3rt/stonksbeat $ make setup
make: *** No rule to make target 'setup'.  Stop.

Following through the documentation it seems that the configuration files have already been created, so perhaps this step is no longer necessary? I don't know for sure by following the documentation alone.

It would be nice if the document can clarify if this is expected or to update this document in case anything has changed in the process. It would also be nice if the document can go more into detail about what the template files are? I don't see that being linked to any examples, unlike the configuration files are.

@robb3rt robb3rt added docs libbeat Team:Docs Label for the Observability docs team labels Mar 20, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/obs-docs (Team:Docs)

cavokz added a commit that referenced this issue Apr 6, 2021
* Remove trailing whitespace

* Fix 'make setup' instructions for a new beat

In "Fetching Dependencies and Setting up the Beat" the user is
instructed to run 'make setup' in the newly created beat directory.

Such command fails with error:

  make: *** No rule to make target 'setup'.  Stop.

The problem and its fix are mentioned on forum [0] and reported in
issue #24660.

[0] https://discuss.elastic.co/t/make-no-rule-to-make-target-setup-stop-custom-beat/229231

* Correct 'make setup' also in generated docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs libbeat Team:Docs Label for the Observability docs team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants