Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Heartbeat] Params undocumented for browser docs #27217

Closed
andrewvc opened this issue Aug 3, 2021 · 1 comment · Fixed by #27303
Closed

[Heartbeat] Params undocumented for browser docs #27217

andrewvc opened this issue Aug 3, 2021 · 1 comment · Fixed by #27303
Assignees
@andrewvc
Labels
bug docs Heartbeat needs_team Indicates that the issue/PR needs a Team:* label v7.14.0

Comments

@andrewvc
Copy link
Contributor

andrewvc commented Aug 3, 2021

The params option is not documented on https://www.elastic.co/guide/en/beats/heartbeat/master/monitor-browser-options.html . See https://github.com/elastic/synthetics-demo/blob/main/heartbeat/monitors.d/ecommerce-zipurl.yml for an example
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Aug 3, 2021
@botelastic
Copy link

botelastic bot commented Aug 3, 2021

This issue doesn't have a Team:<team> label.

@andrewvc andrewvc added the bug label Aug 3, 2021
@andrewvc andrewvc self-assigned this Aug 10, 2021
andrewvc added a commit to andrewvc/beats that referenced this issue Aug 10, 2021
@andrewvc
[Uptime] Document params browser option, fix docs hierarchy.
6f9ae7a 
Fixes elastic#27217 and also improves the ordering of documentation here,
putting the most used options first, and the least used last.
@andrewvc andrewvc mentioned this issue Aug 10, 2021
Merged
andrewvc added a commit that referenced this issue Aug 10, 2021
@andrewvc @bmorelli25
[Uptime] Document params browser option, fix docs hierarchy. (#27303)
07b546d 
* [Uptime] Document `params` browser option, fix docs hierarchy.

Fixes #27217 and also improves the ordering of documentation here,
putting the most used options first, and the least used last.

* Update heartbeat/docs/monitors/monitor-browser.asciidoc

Co-authored-by: Brandon Morelli <bmorelli25@gmail.com>

* Update heartbeat/docs/monitors/monitor-browser.asciidoc

Co-authored-by: Brandon Morelli <bmorelli25@gmail.com>

Co-authored-by: Brandon Morelli <bmorelli25@gmail.com>
mergify bot pushed a commit that referenced this issue Aug 10, 2021
@andrewvc
[Uptime] Document params browser option, fix docs hierarchy. (#27303)
e53197d 
* [Uptime] Document `params` browser option, fix docs hierarchy.

Fixes #27217 and also improves the ordering of documentation here,
putting the most used options first, and the least used last.

* Update heartbeat/docs/monitors/monitor-browser.asciidoc

Co-authored-by: Brandon Morelli <bmorelli25@gmail.com>

* Update heartbeat/docs/monitors/monitor-browser.asciidoc

Co-authored-by: Brandon Morelli <bmorelli25@gmail.com>

Co-authored-by: Brandon Morelli <bmorelli25@gmail.com>
(cherry picked from commit 07b546d)
mergify bot pushed a commit that referenced this issue Aug 10, 2021
@andrewvc
[Uptime] Document params browser option, fix docs hierarchy. (#27303)
acb9f9d 
* [Uptime] Document `params` browser option, fix docs hierarchy.

Fixes #27217 and also improves the ordering of documentation here,
putting the most used options first, and the least used last.

* Update heartbeat/docs/monitors/monitor-browser.asciidoc

Co-authored-by: Brandon Morelli <bmorelli25@gmail.com>

* Update heartbeat/docs/monitors/monitor-browser.asciidoc

Co-authored-by: Brandon Morelli <bmorelli25@gmail.com>

Co-authored-by: Brandon Morelli <bmorelli25@gmail.com>
(cherry picked from commit 07b546d)
andrewvc added a commit that referenced this issue Aug 11, 2021
@mergify @andrewvc
[Uptime] Document params browser option, fix docs hierarchy. (#27303)…
e1d6168 
… (#27304)

* [Uptime] Document `params` browser option, fix docs hierarchy.

Fixes #27217 and also improves the ordering of documentation here,
putting the most used options first, and the least used last.

* Update heartbeat/docs/monitors/monitor-browser.asciidoc

Co-authored-by: Brandon Morelli <bmorelli25@gmail.com>

* Update heartbeat/docs/monitors/monitor-browser.asciidoc

Co-authored-by: Brandon Morelli <bmorelli25@gmail.com>

Co-authored-by: Brandon Morelli <bmorelli25@gmail.com>
(cherry picked from commit 07b546d)

Co-authored-by: Andrew Cholakian <andrew@andrewvc.com>
andrewvc added a commit that referenced this issue Aug 11, 2021
@mergify @andrewvc
[Uptime] Document params browser option, fix docs hierarchy. (#27303)…
a94372c 
… (#27305)

* [Uptime] Document `params` browser option, fix docs hierarchy.

Fixes #27217 and also improves the ordering of documentation here,
putting the most used options first, and the least used last.

* Update heartbeat/docs/monitors/monitor-browser.asciidoc

Co-authored-by: Brandon Morelli <bmorelli25@gmail.com>

* Update heartbeat/docs/monitors/monitor-browser.asciidoc

Co-authored-by: Brandon Morelli <bmorelli25@gmail.com>

Co-authored-by: Brandon Morelli <bmorelli25@gmail.com>
(cherry picked from commit 07b546d)

Co-authored-by: Andrew Cholakian <andrew@andrewvc.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andrewvc andrewvc

Labels
bug docs Heartbeat needs_team Indicates that the issue/PR needs a Team:* label v7.14.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Uptime] Document params browser option, fix docs hierarchy. andrewvc/beats
2 participants
@andrewvc @paulb-elastic