-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Metricbeat] gcp: fields do not respect naming best practices #27231
Labels
Team:Integrations
Label for the Integrations team
Comments
botelastic
bot
added
the
needs_team
Indicates that the issue/PR needs a Team:* label
label
Aug 4, 2021
Pinging @elastic/integrations (Team:Integrations) |
botelastic
bot
removed
the
needs_team
Indicates that the issue/PR needs a Team:* label
label
Aug 4, 2021
8 tasks
endorama
added a commit
to endorama/beats
that referenced
this issue
Aug 17, 2021
In elastic#27231 I discovered that all `gcp` metricsets do not respect the Beats naming conventions. In order to preserve consistency across metricset this commit reverts the changes that aligned the newly added metrics to naming conventions.
endorama
changed the title
[Metricbeat] gcp: fields do not respect ECS and naming best practices
[Metricbeat] gcp: fields do not respect naming best practices
Sep 22, 2021
After reading through the code I learnt that ECS fields are exported: beats/x-pack/metricbeat/module/gcp/metrics/metricset.go Lines 334 to 348 in 86004dd
Still Beats naming conventions are not respected. |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
While working at #26824 I noticed that the current implementation of the
gcp
module for Metricbeat does not seem to align to naming conventions.Examples:
gcp.compute.instance.uptime.value
is a value in seconds, for whichsec
suffix should be usedgcp.compute.instance.firewall.dropped_bytes_count.value
is a bytes value, for whichbytes
suffix should be usedThe text was updated successfully, but these errors were encountered: