Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support for condition on bool type #5659

Closed
TomonoriSoejima opened this issue Nov 21, 2017 · 4 comments
Closed

add support for condition on bool type #5659

TomonoriSoejima opened this issue Nov 21, 2017 · 4 comments
Labels
enhancement needs_team Indicates that the issue/PR needs a Team:* label Stalled

Comments

@TomonoriSoejima
Copy link

TomonoriSoejima commented Nov 21, 2017 •
edited
Loading

Currently

Doc does not support bool type.

With the equals condition, you can compare if a field has a certain value. The condition accepts only an integer or a string value.

When I did so, I got this warning packetbeat.

2017/11/21 01:10:50.019224 condition.go:235: WARN unexpected type bool in equals condition as it accepts only integers and strings.
@ewgRa ewgRa mentioned this issue Dec 23, 2017
Merged
ruflin pushed a commit that referenced this issue Jan 25, 2018
@ewgRa @ruflin
Add support for condition on bool type (#5954)
2ebb47c 
Add ability to use bool in processor conditions, related to #5659
@ewgRa ewgRa mentioned this issue Feb 5, 2018
Closed
@ewgRa
Copy link
Contributor

ewgRa commented Feb 5, 2018

This problem looks like duplicate of #4637, probably one of them can be closed in favor of another.

Merged PR #5954 looks like solution for both issues.

@ruflin
Copy link
Member

ruflin commented Feb 12, 2018

Closing this as #5954 was merged.

@ewgRa Thanks for the ping.

@botelastic
Copy link

botelastic bot commented Jul 9, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@botelastic botelastic bot added Stalled needs_team Indicates that the issue/PR needs a Team:* label labels Jul 9, 2020
@botelastic
Copy link

botelastic bot commented Jul 9, 2020

This issue doesn't have a Team:<team> label.

@botelastic botelastic bot closed this as completed Aug 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement needs_team Indicates that the issue/PR needs a Team:* label Stalled
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ruflin @ewgRa @TomonoriSoejima