Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mix of enabled:false and enabled:true in metricbeat.reference.yml #6672

Closed
ruflin opened this issue Mar 27, 2018 · 2 comments
Closed

Mix of enabled:false and enabled:true in metricbeat.reference.yml #6672

ruflin opened this issue Mar 27, 2018 · 2 comments
Labels
docs Metricbeat Metricbeat module

Comments

@ruflin
Copy link
Member

ruflin commented Mar 27, 2018

In the metricbeat.reference.yml we have a mix of modules which have enabled: false and some which are missing it. We should either have all modules enabled or disabled by default. As we normally go with the default I suggest to have all modules enabled by default, meaning having with each module config a line enabled: true.
This was referenced Mar 27, 2018
Closed
Merged
@dedemorton
Copy link
Contributor

@ruflin Can we close this now?

@ruflin
Copy link
Member Author

ruflin commented Jul 11, 2018

Yes

@ruflin ruflin closed this as completed Jul 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
docs Metricbeat Metricbeat module
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ruflin @dedemorton