Set default metricsets for modules

[ruflin]

Recently the feature to set default metricsets for a module were introduced. If a module is enabled an no metricsets are set, this list of metricsets is used. Now for each module the metricsets must be defined. In general this is all metricsets which are GA but there might be some exceptions like prometheus where the default one is only collector.

This issue is to track the progress on setting the defaults metricsets for all modules.

• aerospike Set namespace as default metricset in Aerospike module #6669
• apache Set status as default metricset in Apache module #6673
• ceph Set all ceph metrics as default in metricbeat module #6682
• couchbase Set all couchbase metricsets as default in metricbeat module. #6683
• docker Set default metricsets in Docker module #6718
• dropwizard Set collector as default in dropwizard module #6719
• elasticsearch Set all metricsets as default in Elasticsearch module #6755
• etcd Set all metricsets as default in etcd module #6756
• golang
• graphite Set server metricset in graphite as default #6757
• haproxy Set all metricsets as default for HAProxy module #6758
• http
• jolokia
• kafka Make all metricsets in Kafka module defaults. #6759
• kibana Set status as default metricset for Kibana module #6762
• kubernetes Set default metricsets for kubernetes module. #6764
• logstash Set all metricsets as default for Logstash module #6763
• memcached Set stats as default metricset for memcached module #6765
• mongodb Set default metricsets for mongodb module #6766
• munin Set node as default metricset for munin #6767
• mysql Set status as default in mysql module #6769
• nginx Set stubstatus as default metricset for nginx module #6770
• php_fpm Set pool as default metricset for php_fpm module #6768
• postgresql Set default metricsets for postgresql module #6761
• prometheus Update doc and reference config for prometheus default metricset #6747 (and Make collector default prometheus metricset #6636)
• rabbitmq Set default metricsets for rabbitmq module #6743
• redis Set default metricsets for redis module #6742
• system Set default metricsets for system module #6689
• uwsgi Set default metricset for uwsgi module #6688
• vsphere Set default metricsets in vsphere module #6676
• windows Set default metricset in windows module to service #6675
• zookeeper Set default metricset in zookeeper module #6674

[ruflin]

@jsoriano I started working from the top of the list.

[ruflin]

@jsoriano When changing each module I also directly check #6672 So I add enabled: true to the reference config file (if there is one) and remove enabled: * from the short config.

Other changes I do:

• Add a note to the docs
• Add an entry to the changelog

[jsoriano]

I start from the bottom then :)

[ruflin]

All changelog entries which have to be added later. Lets use this comment to collect them.

- Set all metricsets as default metricsets in Ceph module. {pull}6676[6676]
- Set `container`, `cpu`, `diskio`, `healthcheck`, `info`, `memory` and `network` in docker module as default. {pull}6718[6718]
- Set `cpu`, `load`, `memory`, `network`, `process` and `process_summary` as default metricsets in system module. {pull}6689[6689]
- Set `collector` as default metricset in Dropwizard module. {pull}6669[6669]
- Set `info` and `keyspace` as default metricsets in redis module. {pull}6742[6742]
- Set `connection` as default metricset in rabbitmq module. {pull}6743[6743]
- Set all metricsets as default metricsets in Elasticsearch module. {pull}6755[6755]
- Set all metricsets as default metricsets in Etcd module. {pull}6756[6756]
- Set server metricsets as default in Graphite module. {pull}6757[6757]
- Set all metricsets as default metricsets in HAProxy module. {pull}6758[6758]
- Set all metricsets as default metricsets in Kafka module. {pull}6759[6759]
- Set all metricsets as default metricsets in postgresql module. {pull}6761[6761]
- Set status metricsets as default in Kibana module. {pull}6762[6762]
- Set all metricsets as default metricsets in Logstash module. {pull}6763[6763]
- Set `container`, `node`, `pod`, `system`, `volume` as default in Kubernetes module. {pull} 6764[6764]
- Set `stats` as default in memcached module. {pull}6765[6765]
- Set all metricsets as default metricsets in Mongodb module. {pull}6766[6766]
- Set `pool` as default metricset for php_fpm module. {pull}6768[6768]
- Set `status` as default metricset for mysql module. {pull} 6769[6769]
- Set `stubstatus` as default metricset for nginx module. {pull}6770[6770]

[ruflin]

I left the golang module untouched as it's still experimental and I think in this stage we should not have defaults.

[ruflin]

I checked off http and suggest not to add any defaults. For the json metricset it is always required to set a correct path as / is probably not the one that is expected. And for the server one not sure if the expectation of enabling the http module would be that a port is opened.

[ruflin]

Similar thing to the above applies for Jolokia and I also checked it off. The jmx metricset always requires manual configuration so it does not make much sense to have it as a default.

[ruflin]

Closing as all changes have been merged and changelog PR is open here #6781