Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make README.html.tmpl configurable in DMG packaging #7680

Closed
andrewkroh opened this issue Jul 23, 2018 · 1 comment
Closed

Make README.html.tmpl configurable in DMG packaging #7680

andrewkroh opened this issue Jul 23, 2018 · 1 comment
Labels
enhancement Packaging Stalled Team:Integrations Label for the Integrations team

Comments

@andrewkroh
Copy link
Member

Currently the README.html.tmpl file that is included in DMG files is hard-coded. External projects (e.g. apm-server) should be able to customize the README used in the installer.

beats/dev-tools/mage/dmgbuilder.go

Lines 157 to 159 in ff45ef8

b.MustExpandFile(
filepath.Join(b.beatsDir, "dev-tools/packaging/templates/darwin/README.html.tmpl"),
filepath.Join(resourcesDir, "README.html"))

@roncohen roncohen mentioned this issue Jul 23, 2018
Merged
@andresrc andresrc added Team:Integrations Label for the Integrations team and removed Team:Beats labels Mar 6, 2020
@botelastic
Copy link

botelastic bot commented Feb 4, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@botelastic botelastic bot added the Stalled label Feb 4, 2021
@botelastic botelastic bot closed this as completed Mar 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Packaging Stalled Team:Integrations Label for the Integrations team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ycombinator @andresrc @andrewkroh