Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update beats framework to a314e34 #1167

Merged
merged 3 commits into from
Jul 23, 2018
Merged

Conversation

roncohen
Copy link
Contributor

@roncohen roncohen commented Jul 23, 2018

No description provided.

@roncohen
Copy link
Contributor Author

ran into this now: failed building apm-server-oss type=dmg for platform=darwin/amd64: failed to build internal beat pkg: copy failed: cannot stat source file apm-server.reference.yml: stat apm-server.reference.yml: no such file or directory cc @andrewkroh

@@ -521,7 +511,7 @@
},
{
"path": "github.com/elastic/go-structform/internal/visitors",
"revision": "",
"revision": "v0.0.4",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks strange, also I could not find github.com/elastic/go-structform/internal/visitors, but github.com/elastic/go-structform/visitors. Same for github.com/elastic/go-structform/internal/ubjson above.

That looks like a potential issue in beats though, elastic/beats#7676

@simitt
Copy link
Contributor

simitt commented Jul 23, 2018

oh, just saw your comment above now.

@roncohen
Copy link
Contributor Author

Added a commit to fix the problem mentioned above apm-server.reference.yml: no such file or directory.

@roncohen
Copy link
Contributor Author

This came out of the investigation with @andrewkroh: elastic/beats#7680
DMGs are not likely to be built for 6.4 anyway, so we should move forward on this.

@roncohen
Copy link
Contributor Author

DMG building still fails, but that is not going to be used for now, so i'll merge. For reference, here's the error:

>> package: Building apm-server-oss type=dmg for platform=darwin/amd64
** BUILD FAILED **


The following build commands failed:
	CompileXIB beats-preference-pane/Base.lproj/EditorWindow.xib
	CompileXIB beats-preference-pane/Base.lproj/BeatView.xib
	CompileXIB beats-preference-pane/Base.lproj/BeatsPrefPane.xib
(3 failures)
Error: running "xcodebuild build -project beats-preference-pane.xcodeproj -alltargets -configuration Release CODE_SIGN_IDENTITY= CODE_SIGNING_REQUIRED=NO" failed with exit code 65

@roncohen roncohen merged commit c5b442f into elastic:master Jul 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants