Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace _xpack/monitoring/* with _monitoring/* ES API calls #9480

Closed
ycombinator opened this issue Dec 10, 2018 · 4 comments · Fixed by #11203
Closed

Replace _xpack/monitoring/* with _monitoring/* ES API calls #9480

ycombinator opened this issue Dec 10, 2018 · 4 comments · Fixed by #11203
Assignees
@ycombinator
Labels
Feature:Stack Monitoring monitoring

Comments

@ycombinator
Copy link
Contributor

Starting 7.0, the _xpack/monitoring/* API endpoints in Elasticsearch will be deprecated in favor of monitoring/* API endpoints. We should update any references to the deprecated endpoints in the Beats codebase and replace them with the new ones.
@ycombinator
Copy link
Contributor Author

Pinging @elastic/stack-monitoring

@jakelandis
Copy link

@urso @ycombinator - Can we try to get this is in for 7.0.0 ? While testing, I noticed that this can create quite a bit of noise in the logs for Elasticsearch. The change should be easy and /_xpack/monitoring/_bulk --> /_monitoring/bulk. Here is the PR for Logstash: https://github.com/elastic/logstash/pull/10528/files

@ycombinator ycombinator self-assigned this Mar 11, 2019
@ycombinator
Copy link
Contributor Author

@jakelandis Yes, I will work on this ASAP.

@ycombinator
Copy link
Contributor Author

Just as an FYI: looks like this somehow got missed in #9656.

@ycombinator ycombinator mentioned this issue Mar 11, 2019
Merged
ycombinator added a commit that referenced this issue Mar 19, 2019
@ycombinator
Use different monitoring bulk API paths depending on ES version (#11203)
44c40c9 
Resolves #9480.

Starting Elasticsearch 7.0.0, Beats should ship their monitoring data to the `_monitoring/bulk` Elasticsearch API endpoint. Prior to 7.0.0, `_xpack/monitoring/_bulk` should be used. This PR implements this version-based conditional logic.

I used Wireshark to look at the ES API endpoints being hit.

Running this PR with ES 8.0.0 or ES 7.0.0, I confirmed that the `POST _monitoring/bulk` endpoint was being hit:

<img width="1436" alt="Screen Shot 2019-03-14 at 10 55 52 AM" src="https://user-images.githubusercontent.com/51061/54380101-ed567780-4647-11e9-8ed1-9b9020bb85d4.png">

And running this PR with ES 6.7.0, I confirmed that the `POST _xpack/monitoring/_bulk` endpoint was being hit:

<img width="1437" alt="Screen Shot 2019-03-14 at 10 56 42 AM" src="https://user-images.githubusercontent.com/51061/54380094-eaf41d80-4647-11e9-8658-d9a6ba14541b.png">
@ycombinator ycombinator mentioned this issue Mar 19, 2019
Merged
ycombinator added a commit that referenced this issue Mar 19, 2019
@ycombinator
Cherry-pick #11203 to 7.0: Use different monitoring bulk API paths de…
b5e4459 
…pending on ES version (#11323)

Cherry-pick of PR #11203 to 7.0 branch. Original message: 

Resolves #9480.

Starting Elasticsearch 7.0.0, Beats should ship their monitoring data to the `_monitoring/bulk` Elasticsearch API endpoint. Prior to 7.0.0, `_xpack/monitoring/_bulk` should be used. This PR implements this version-based conditional logic.

I used Wireshark to look at the ES API endpoints being hit.

Running this PR with ES 8.0.0 or ES 7.0.0, I confirmed that the `POST _monitoring/bulk` endpoint was being hit:

<img width="1436" alt="Screen Shot 2019-03-14 at 10 55 52 AM" src="https://user-images.githubusercontent.com/51061/54380101-ed567780-4647-11e9-8ed1-9b9020bb85d4.png">

And running this PR with ES 6.7.0, I confirmed that the `POST _xpack/monitoring/_bulk` endpoint was being hit:

<img width="1437" alt="Screen Shot 2019-03-14 at 10 56 42 AM" src="https://user-images.githubusercontent.com/51061/54380094-eaf41d80-4647-11e9-8658-d9a6ba14541b.png">
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ycombinator ycombinator

Labels
Feature:Stack Monitoring monitoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use different monitoring bulk API paths depending on ES version ycombinator/beats
2 participants
@ycombinator @jakelandis