Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename id of Kafka overview dashboard #10067

Merged
merged 1 commit into from
Jan 16, 2019
Merged

Rename id of Kafka overview dashboard #10067

merged 1 commit into from
Jan 16, 2019

Conversation

ruflin
Copy link
Collaborator

@ruflin ruflin commented Jan 15, 2019

The Kafka had the same id as the title which complicates the automatic conversion to 7.x dashboards, see #9998. This is extracted from the migration PR to be able to easily reset the other data again when needed.

@ruflin
Rename id of Kafka overview dashboard
f04f2f7 
The Kafka had the same id as the title which complicates the automatic conversion to 7.x dashboards, see elastic#9998. This is extracted from the migration PR to be able to easily reset the other data again when needed.
@ruflin ruflin added module Metricbeat Metricbeat :Dashboards Team:Integrations Label for the Integrations team labels Jan 15, 2019
@ruflin ruflin self-assigned this Jan 15, 2019
@ruflin ruflin requested a review from jsoriano January 15, 2019 08:42
@ruflin ruflin requested a review from a team as a code owner January 15, 2019 08:42
@ruflin ruflin mentioned this pull request Jan 15, 2019
Merged
@jsoriano
Copy link
Member

What about changing all dashboard ids to uuids as is done when exporting from kibana by default?

@jsoriano
Copy link
Member

And we also have to think that changing ids will make upgrades to keep old dashboards. Users will see two dashboards and won't be able to know which one is the new one.

@jsoriano jsoriano closed this Jan 15, 2019
@jsoriano
Copy link
Member

Closed by mistake, sorry 😬

@jsoriano jsoriano reopened this Jan 15, 2019
@ruflin
Copy link
Collaborator Author

ruflin commented Jan 15, 2019

This is only a prerequisit for #9998 There all the titles will be renamed so everyone knows which dashboards are which.

We could convert all id's to uuid for the new dashboards but I rather discuss this in #9998

jsoriano
jsoriano approved these changes Jan 15, 2019
View reviewed changes
Copy link
Member

@jsoriano jsoriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, approved as pre-requisite for #9998

@ruflin
Copy link
Collaborator Author

ruflin commented Jan 15, 2019

jenkins, test this

@ruflin ruflin merged commit 7f14017 into elastic:master Jan 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsoriano jsoriano jsoriano approved these changes

Assignees

@ruflin ruflin

Labels
:Dashboards Metricbeat Metricbeat module Team:Integrations Label for the Integrations team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ruflin @jsoriano