-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[functionbeat] Allow Kinesis to deploy using the CLI. #10116
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit add support to publish a function that listen to a Kinesis stream using the CLI. Features: - Kinesis can now defined in the YML. - AWS installer can now define a custom policies to be added to the lambda role. - Kinesis support `TRIM_HORIZON` and `LATEST` as the starting position strategy, `AT_TIMESTAMP` is currently not support because the cloudformation API doesn't accept a TIMESTAMP when configuring the subscription. - Kinesis allow to configure the batch size.
ph
changed the title
[WIP] Allow Kinesis to deploy using the CLI.
Allow Kinesis to deploy using the CLI.
Jan 17, 2019
ph
commented
Jan 17, 2019
ph
changed the title
Allow Kinesis to deploy using the CLI.
[functionbeat] Allow Kinesis to deploy using the CLI.
Jan 18, 2019
urso
approved these changes
Jan 20, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@kvch please also have a look.
jenkins test this please |
kvch
approved these changes
Jan 23, 2019
backport for 6.x |
Jenkins test this please |
ph
added a commit
to ph/beats
that referenced
this pull request
Jan 25, 2019
This commit add support to publish a function that listen to a Kinesis stream using the CLI. Features: - Kinesis can now be defined in the YML. - AWS installer can now define a custom policies to be added to the lambda role. - Kinesis support `TRIM_HORIZON` and `LATEST` as the starting position strategy, `AT_TIMESTAMP` is currently not supported because the cloudformation API doesn't accept a TIMESTAMP when configuring the subscription. - Kinesis allow to configure the batch size. (cherry picked from commit 5b4bb7f)
ph
added
v6.7.0
and removed
needs_backport
PR is waiting to be backported to other branches.
labels
Jan 25, 2019
ph
added a commit
that referenced
this pull request
Jan 26, 2019
ph
added a commit
that referenced
this pull request
Jan 29, 2019
This commit add support to publish a function that listen to a Kinesis stream using the CLI. Features: - Kinesis can now be defined in the YML. - AWS installer can now define a custom policies to be added to the lambda role. - Kinesis support `TRIM_HORIZON` and `LATEST` as the starting position strategy, `AT_TIMESTAMP` is currently not supported because the cloudformation API doesn't accept a TIMESTAMP when configuring the subscription. - Kinesis allow to configure the batch size. (cherry picked from commit 5b4bb7f)
ph
added a commit
to ph/beats
that referenced
this pull request
Jan 29, 2019
**NOTES:** This PR is based on top of elastic#10116 Correctly add the permissions to the lambda role when monitoring SQS queue. Fixes: elastic#9152 (cherry picked from commit dc963c4)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit add support to publish a function that listen to a Kinesis
stream using the CLI.
Features:
role.
TRIM_HORIZON
andLATEST
as the starting positionstrategy,
AT_TIMESTAMP
is currently not supported because thecloudformation API doesn't accept a TIMESTAMP when configuring the
subscription.