Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add remaining memory metrics of pods in Kubernetes metricbeat module #10157

Merged
merged 1 commit into from
Jan 21, 2019
Merged

Add remaining memory metrics of pods in Kubernetes metricbeat module #10157

merged 1 commit into from
Jan 21, 2019

Conversation

vjsamuel
Copy link
Contributor

Some of the metrics available on the summary endpoint are missing in the kubernetes pod metricset. This PR attempts to add them back.

@vjsamuel vjsamuel requested a review from a team as a code owner January 18, 2019 05:05
@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@vjsamuel vjsamuel force-pushed the add_pod_metrics branch 2 times, most recently from 7da53e4 to 7f4a374 Compare January 18, 2019 05:23
ruflin
ruflin approved these changes Jan 18, 2019
View reviewed changes
Copy link
Member

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but would like to also get @exekias review on this one.

@vjsamuel vjsamuel requested a review from a team as a code owner January 19, 2019 05:44
exekias
exekias approved these changes Jan 21, 2019
View reviewed changes
Copy link
Contributor

@exekias exekias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @vjsamuel!

@exekias exekias added Metricbeat Metricbeat needs_backport PR is waiting to be backported to other branches. containers Related to containers use case v6.7.0 labels Jan 21, 2019
@exekias exekias merged commit e14225c into elastic:master Jan 21, 2019
jsoriano pushed a commit to jsoriano/beats that referenced this pull request Jan 31, 2019
@vjsamuel @jsoriano
Add remaining memory metrics of pods in Kubernetes metricbeat module (e…
b337a2e 
…lastic#10157)

(cherry picked from commit e14225c)
@jsoriano jsoriano mentioned this pull request Jan 31, 2019
Merged
@jsoriano jsoriano removed the needs_backport PR is waiting to be backported to other branches. label Jan 31, 2019
@jsoriano jsoriano mentioned this pull request Jan 31, 2019
Merged
jsoriano added a commit that referenced this pull request Feb 2, 2019
@jsoriano @vjsamuel
Cherry-pick #10157 to 6.x: Add remaining memory metrics of pods in Ku…
c43ce99 
…bernetes metricbeat module (#10454)

(cherry picked from commit e14225c)

Co-authored-by: Vijay Samuel <vjsamuel1990@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@exekias exekias exekias approved these changes

@ruflin ruflin ruflin approved these changes

Assignees
No one assigned
Labels
containers Related to containers use case Metricbeat Metricbeat v6.7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vjsamuel @elasticmachine @ruflin @exekias @jsoriano