Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Making the Windows module GA #10163

Merged
merged 5 commits into from
Jan 21, 2019
Merged

Making the Windows module GA #10163

merged 5 commits into from
Jan 21, 2019

Conversation

ruflin
Copy link
Member

@ruflin ruflin commented Jan 18, 2019

The perfmon metricset is still in Beta. There are a few improvements I would like to see like #6584 before pushing this to GA. These changes could be breaking changes.

@ruflin
Making the Windows module GA
b3826c2 
The perfmon metricset is still in Beta. There are a few improvements I would like to see like elastic#6584 before pushing this to GA. These changes could be breaking changes.
@ruflin ruflin added module review Metricbeat Metricbeat needs_backport PR is waiting to be backported to other branches. Team:Integrations Label for the Integrations team labels Jan 18, 2019
@ruflin ruflin self-assigned this Jan 18, 2019
@ruflin ruflin requested review from a team as code owners January 18, 2019 11:52
@ruflin ruflin requested a review from a team as a code owner January 18, 2019 11:54
@jsoriano
Copy link
Member

I added the blocked tag to avoid merging it if we consider that we want #6584 and we think this may be a breaking change.

@ruflin
Copy link
Member Author

ruflin commented Jan 21, 2019

The perfmon metricset is still in beta, only the service metricset it release as GA.

jsoriano
jsoriano approved these changes Jan 21, 2019
View reviewed changes
Copy link
Member

@jsoriano jsoriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok to make only the service metricset GA by now.

@ruflin ruflin merged commit dbfa3ef into elastic:master Jan 21, 2019
@ruflin ruflin deleted the windows-ga branch January 21, 2019 15:44
ruflin added a commit to ruflin/beats that referenced this pull request Jan 21, 2019
@ruflin
Making the Windows module GA (elastic#10163)
17310d8 
The perfmon metricset is still in Beta. There are a few improvements I would like to see like elastic#6584 before pushing this to GA. These changes could be breaking changes.

(cherry picked from commit dbfa3ef)
@ruflin ruflin mentioned this pull request Jan 21, 2019
Merged
@ruflin ruflin added v6.7.0 and removed needs_backport PR is waiting to be backported to other branches. labels Jan 21, 2019
ruflin added a commit that referenced this pull request Jan 22, 2019
@ruflin
Cherry-pick #10163 to 6.x: Making the Windows module GA (#10221)
435631b 
The perfmon metricset is still in Beta. There are a few improvements I would like to see like #6584 before pushing this to GA. These changes could be breaking changes.

(cherry picked from commit dbfa3ef)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsoriano jsoriano jsoriano approved these changes

Assignees

@ruflin ruflin

Labels
blocked Metricbeat Metricbeat module review Team:Integrations Label for the Integrations team v6.7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ruflin @jsoriano