Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove field url.hostname. #10469

Merged
merged 1 commit into from
Feb 1, 2019
Merged

Conversation

webmat
Copy link
Contributor

@webmat webmat commented Jan 31, 2019

This field was defined temporarily, at the very beginning of the ECS transition and should no longer be used. url.domain is what should be used instead.

@webmat webmat requested review from a team as code owners January 31, 2019 18:37
@webmat webmat self-assigned this Jan 31, 2019
@webmat webmat added in progress Pull request is currently in progress. libbeat ecs labels Jan 31, 2019
@ruflin ruflin mentioned this pull request Jan 31, 2019
@webmat webmat added review and removed in progress Pull request is currently in progress. labels Jan 31, 2019
@webmat webmat requested a review from ruflin January 31, 2019 19:09
This field was defined temporarily, at the very beginning of the ECS transition and should no longer be used.
Copy link
Member

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure is not related.

@webmat webmat merged commit f2b783d into elastic:master Feb 1, 2019
@webmat webmat deleted the ecs-rm-url-hostname branch February 1, 2019 13:21
@monicasarbu monicasarbu changed the title Remove field url.hostname. Remove field url.hostname. Feb 4, 2019
DStape pushed a commit to DStape/beats that referenced this pull request Aug 20, 2019
This field was defined temporarily, at the very beginning of the ECS transition and is no longer used. `url.domain` should be used in its place.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants