Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set file.origin type to keyword #10544

Merged
merged 2 commits into from
Feb 4, 2019
Merged

Conversation

adriansr
Copy link
Contributor

@adriansr adriansr commented Feb 4, 2019

The file.origin field is set by auditbeat's file_integrity module under macOs. This field was set to text type instead of keyword.

Copy link
Member

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks good to me but needs an entry in the Changelog as this is a breaking change.

The `file.origin` field is set by auditbeat's file_integrity module
under macOs. This field was set to `text` type instead of `keyword`.
@adriansr adriansr changed the title Set common.file.origin type to keyword Set file.origin type to keyword Feb 4, 2019
@adriansr
Copy link
Contributor Author

adriansr commented Feb 4, 2019

@ruflin can you have another look?

@@ -22,6 +22,8 @@ https://github.com/elastic/beats/compare/v7.0.0-alpha2...master[Check the HEAD d

*Auditbeat*

- Field `file.origin` changed type from `text` to `keyword`. {pull}10544[10544]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should end up in CHANGELOG.next.asciidoc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants