Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add filters to AWS EC2 kibana dashboard and pie chart to show instance state #10596

Merged
merged 8 commits into from
Feb 19, 2019
Merged

Add filters to AWS EC2 kibana dashboard and pie chart to show instance state #10596

merged 8 commits into from
Feb 19, 2019

Conversation

kaiyan-sheng
Copy link
Contributor

@kaiyan-sheng kaiyan-sheng commented Feb 5, 2019 •
edited
Loading

Add filters for ec2 overview dashboard: aws region, ec2 machine type and availability zone. Also added a pie chart to show ec2 instance state.
screen shot 2019-02-08 at 6 17 05 pm

@kaiyan-sheng kaiyan-sheng requested a review from a team as a code owner February 5, 2019 22:51
@kaiyan-sheng kaiyan-sheng self-assigned this Feb 5, 2019
@kaiyan-sheng kaiyan-sheng added Metricbeat Metricbeat Team:Integrations Label for the Integrations team labels Feb 5, 2019
@ruflin ruflin requested a review from sayden February 6, 2019 12:21
@ruflin ruflin added the needs_backport PR is waiting to be backported to other branches. label Feb 6, 2019
@ruflin
Copy link
Member

ruflin commented Feb 6, 2019

@kaiyan-sheng I added the needs_backport label as we might need to backport this to the 7.0 branch depending on when it gets merged.

@kaiyan-sheng
Copy link
Contributor Author

@ruflin 👍 Thank you!

@kaiyan-sheng kaiyan-sheng requested a review from a team as a code owner February 6, 2019 20:30
@jsoriano
Copy link
Member

jsoriano commented Feb 7, 2019

@kaiyan-sheng you can also add all the selectors in a single box (like in https://user-images.githubusercontent.com/15763/47107903-d81d1e80-d24a-11e8-8c59-782ca1375275.png)

@kaiyan-sheng
Copy link
Contributor Author

kaiyan-sheng commented Feb 7, 2019 •
edited
Loading

@kaiyan-sheng you can also add all the selectors in a single box (like in https://user-images.githubusercontent.com/15763/47107903-d81d1e80-d24a-11e8-8c59-782ca1375275.png)

@jsoriano Aha good idea! I made the change to combine them in one box :-) Thanks!
screen shot 2019-02-06 at 9 12 18 pm

@ruflin
Copy link
Member

ruflin commented Feb 7, 2019

jenkins, test this

@kaiyan-sheng kaiyan-sheng changed the title Add filters to AWS EC2 kibana dashboard Add filters to AWS EC2 kibana dashboard and pie chart to show instance state Feb 9, 2019
@kaiyan-sheng
Copy link
Contributor Author

The new instance state pie chart showing stopped/terminated states only works with #10627. There are some bugs fixed in there so with that PR, ec2 metricset actually starts reporting events when instance state is not running.

sayden
sayden approved these changes Feb 18, 2019
View reviewed changes
Copy link
Contributor

@sayden sayden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally. Dashboard loads properly but I don't have an AWS account on hand to test more. I think it's OK 👍

@kaiyan-sheng kaiyan-sheng merged commit 59061d4 into elastic:master Feb 19, 2019
@kaiyan-sheng kaiyan-sheng deleted the ec2_kibana branch February 19, 2019 15:46
kaiyan-sheng added a commit that referenced this pull request Feb 23, 2019
@kaiyan-sheng
Cherry-pick to 7.0: Add filters and pie chart in EC2 Kibana Dashboard (…
76e61da 
…#10596) (#10838)

* Add filters to AWS EC2 kibana dashboard and pie chart to show instance state (#10596)

* Add filter to EC2 Overview dashboard

* remove buttons from filters

* Combine filters into one panel

* Add Instance state pie chart

* Add changelog

(cherry picked from commit 59061d4)
@kaiyan-sheng kaiyan-sheng removed the needs_backport PR is waiting to be backported to other branches. label Mar 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sayden sayden sayden approved these changes

Assignees

@kaiyan-sheng kaiyan-sheng

Labels
Metricbeat Metricbeat review Team:Integrations Label for the Integrations team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kaiyan-sheng @ruflin @jsoriano @sayden @alvarolobato