Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Filebeat] Add ecs:false to user_agent processor #10688

Merged
merged 1 commit into from
Feb 12, 2019

Conversation

ruflin
Copy link
Member

@ruflin ruflin commented Feb 12, 2019

To make sure the same data structure is ingested in Elasticsearch 6.7 and 7.0 when running Filebeat 6.7, the user_agent processor flag ecs: false must be set. Otherwise the data structure would change and data structure conflicts would happen (see #10650).

This change requires Elasticsearch to support the ecs: false flag in 7.x.

Adding the ecs: flag will mean Filebeat 6.7 stops working with Elasticsearch 6.5 or older as the flag is not supported.

To make sure the same data structure is ingested in Elasticsearch 6.7 and 7.0 when running Filebeat 6.7, the user_agent processor flag `ecs: false` must be set. Otherwise the data structure would change and data structure conflicts would happen (see elastic#10650).

This change requires Elasticsearch to support the `ecs: false` flag in 7.x.

Adding the `ecs: flag` will mean Filebeat 6.7 stops working with Elasticsearch 6.5 or older as the flag is not supported.
@ruflin
Copy link
Member Author

ruflin commented Feb 12, 2019

@jakelandis This PR introduces the ecs: false flag.

@ruflin ruflin added the Team:Integrations Label for the Integrations team label Feb 12, 2019
@ruflin ruflin self-assigned this Feb 12, 2019
@ruflin ruflin requested review from webmat and jsoriano February 12, 2019 10:34
@ruflin
Copy link
Member Author

ruflin commented Feb 12, 2019

The PR to apply the changes in Elasticsearch can be found here: elastic/elasticsearch#38757

Copy link
Contributor

@sayden sayden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally. All good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocker Filebeat Filebeat module Team:Integrations Label for the Integrations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants