Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Metricbeat] Migrate PostgreSQL bgwriter Metricset to use ReporterV2 interface #10831

Merged
merged 2 commits into from
Mar 5, 2019
Merged

[Metricbeat] Migrate PostgreSQL bgwriter Metricset to use ReporterV2 interface #10831

merged 2 commits into from
Mar 5, 2019

Conversation

sayden
Copy link
Contributor

@sayden sayden commented Feb 19, 2019 •
edited by alvarolobato
Loading

Refer to #10774 for more info

@sayden sayden added Metricbeat Metricbeat Team:Integrations Label for the Integrations team labels Feb 19, 2019
@sayden sayden self-assigned this Feb 19, 2019
@sayden sayden requested a review from a team as a code owner February 19, 2019 16:01
@sayden sayden mentioned this pull request Feb 19, 2019
Closed
62 tasks
@sayden
Copy link
Contributor Author

sayden commented Feb 19, 2019 •
edited
Loading

Error seems unrelated https://travis-ci.org/elastic/beats/jobs/495536983#L5259

@sayden sayden added the review label Feb 28, 2019
jsoriano
jsoriano reviewed Mar 1, 2019
View reviewed changes
Copy link
Member

@jsoriano jsoriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but could you also regenerate the data.json file?

@sayden sayden merged commit 9762b07 into elastic:master Mar 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsoriano jsoriano jsoriano left review comments

@ruflin ruflin ruflin approved these changes

Assignees

@sayden sayden

Labels
Metricbeat Metricbeat review Team:Integrations Label for the Integrations team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sayden @jsoriano @ruflin