Inject clock for docker watcher tests #10870
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsoriano
force-pushed
the
docker-test-watcher-die-flaky
branch
from
f50a82d
to
3ccac15
Compare
jsoriano
force-pushed
the
docker-test-watcher-die-flaky
branch
from
80e2d5b
to
5cdf287
Compare
|
Cool it's a draft!! So does the draft skip the continuous-integration/travis-ci/pr tests? |
Yeah! giving a try to this new feature, it seems to trigger less things, I wonder how this is decided. |
|
Interesting idea with the clock interface. Let's see if it solves the flakiness issue. |
|
Closing this by now, I will try to refactor the docker watcher to reuse the cache in libbeat. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inject clock for docker watcher tests to avoid depending on timing.
Fix #7906