Make geoip steps generic and move to libbeat #10947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewkroh
reviewed
Feb 28, 2019
|
@andrewkroh @ph Can you review my changes? I made the content even more generic because I don't think it makes sense to talk about the location of clients within the docs for some of the Beats. Trying to find a balance between being generic enough, but not too vague. I'll push another change tomorrow to add content to the other Beats, but you can review the latest changes anytime. |
andrewkroh
approved these changes
Mar 21, 2019
dedemorton
added
the
needs_backport
dedemorton
added a commit
to dedemorton/beats
that referenced
this pull request
Mar 25, 2019
* Make geoip steps generic and move to libbeat * Add changes from review * Add topic to all the beats
dedemorton
added a commit
to dedemorton/beats
that referenced
this pull request
Mar 25, 2019
* Make geoip steps generic and move to libbeat * Add changes from review * Add topic to all the beats
dedemorton
removed
the
needs_backport
dedemorton
added a commit
that referenced
this pull request
Apr 3, 2019
dedemorton
added a commit
that referenced
this pull request
Apr 3, 2019
DStape
pushed a commit
to DStape/beats
that referenced
this pull request
Aug 20, 2019
* Make geoip steps generic and move to libbeat * Add changes from review * Add topic to all the beats
DStape
pushed a commit
to DStape/beats
that referenced
this pull request
Aug 20, 2019
…#10947) (elastic#11452) * Make geoip steps generic and move to libbeat (elastic#10947) * Make geoip steps generic and move to libbeat * Add changes from review * Add topic to all the beats * Add link to docs about adding geoip info (elastic#11395)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #10941.
Note that the content is not simply moved. It's also be modified to be more generic and some of the wording has been improved.
TODO:
[] Add a section that describes how to add the field mapping in case the user wants to add a field that's not in the index templatestriking out because the template contains the fields we anticipate users will need.