[Metricbeat] Migrate Kubernetes state_replicaset Metricset to use ReporterV2 interface #10974
Conversation
sayden
added
Metricbeat
|
jenkins, test this |
|
Error in ES module seems unrelated https://beats-ci.elastic.co/job/elastic+beats+pull-request+multijob-linux/beat=metricbeat,label=linux-immutable/5456/console |
sayden
dismissed
ruflin’s stale review
Probably yes, I'll check and ask you to review again. Dismissing to avoid accidental "happy merge"
sayden
added
in progress
sayden
force-pushed
the
migration/mb/reporterv2/kubernetes/state_replicaset
branch
from
d5935d4
to
750b725
Compare
|
jenkins, test this please |
sayden
added
review
and removed
in progress
...ule/kubernetes/state_replicaset/_meta/testdata/kube-state-metrics-v1.3.0.plain-expected.json
Outdated
Show resolved
Hide resolved
sayden
force-pushed
the
migration/mb/reporterv2/kubernetes/state_replicaset
branch
from
750b725
to
79a9a4d
Compare
|
jenkins, test this |
|
|
||
| var moduleFieldsMapStr common.MapStr | ||
| moduleFields, ok := event[mb.ModuleDataKey] | ||
| if ok { |
There was a problem hiding this comment.
Can you file a follow up issue so we improve the prometheus input so we can get rid of this. I think @odacremolbap worked already on some parts.
There was a problem hiding this comment.
Sure, I did some quick test using this https://github.com/elastic/beats/blob/master/metricbeat/module/kubernetes/state_container/state_container_test.go#L29 but it didn't work :(
There was a problem hiding this comment.
I didn't understand why some metricsets were using it and some not
There was a problem hiding this comment.
Not sure I can follow your above comment. I'm ok with the current hack but want to make sure we follow up that is why the ask for an issue.
There was a problem hiding this comment.
As soon as we have migrated all the new interface, I think we can remove the old testing methods. I wanted to keep them around for the migration to make sure we don't miss things.
|
jenkins, test this |
|
I don't think the failures are related. |
Refer to #10774 for more info